accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Josh Elser" <josh.el...@gmail.com>
Subject Re: Review Request 25260: Throw exception on metadata constraint violation, instead of retrying
Date Wed, 03 Sep 2014 15:29:06 GMT


> On Sept. 2, 2014, 10:32 p.m., Josh Elser wrote:
> > test/src/test/java/org/apache/accumulo/test/Accumulo3096IT.java, line 53
> > <https://reviews.apache.org/r/25260/diff/1/?file=674070#file674070line53>
> >
> >     Would be better as an Assert.equals() call with a message as to why we expect
the CVE as the cause.
> 
> kturner wrote:
>     If its not the expected exception, I like throwing it.   Then we see what the stack
trace for the unexpected exception which is useful for debugging.

Ok, I can buy getting the stack trace.


- Josh


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25260/#review52094
-----------------------------------------------------------


On Sept. 3, 2014, 3:17 p.m., kturner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25260/
> -----------------------------------------------------------
> 
> (Updated Sept. 3, 2014, 3:17 p.m.)
> 
> 
> Review request for accumulo.
> 
> 
> Bugs: ACCUMULO-3096
>     https://issues.apache.org/jira/browse/ACCUMULO-3096
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> Throw exception on metadata constraint violation, instead of retrying
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/accumulo/core/client/impl/Writer.java d6762e7 
>   server/base/src/main/java/org/apache/accumulo/server/util/MetadataTableUtil.java 463ca57

>   test/src/test/java/org/apache/accumulo/test/MetaConstraintRetryIT.java PRE-CREATION

> 
> Diff: https://reviews.apache.org/r/25260/diff/
> 
> 
> Testing
> -------
> 
> Ran mvn package w/o incident .   Currently running mvn verify.
> 
> 
> Thanks,
> 
> kturner
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message