accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Park" <>
Subject Re: Review Request 22658: ACCUMULO-2889: Batch metadata updates for new WALs
Date Mon, 01 Sep 2014 11:28:28 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Sept. 1, 2014, 11:28 a.m.)

Review request for accumulo.


Incorporating feedback from kturner. Removed the use of ThreadLocal and batching of updates
happens in TabletServerLogger instead of in the writer class.

Bugs: ACCUMULO-2889

Repository: accumulo


Added additional methods to the Writer class to handle batching. 

Potential risks are that we're now holding onto the locks for a bit longer than we used to.
All tablets present in a batch will have their logLock's locked until the batch is complete.

Diffs (updated)

  core/src/main/java/org/apache/accumulo/core/client/impl/ d6762e7 
  server/base/src/main/java/org/apache/accumulo/server/util/ PRE-CREATION

  server/base/src/main/java/org/apache/accumulo/server/util/ 463ca57

  server/tserver/src/main/java/org/apache/accumulo/tserver/ f9fdacb 
  server/tserver/src/main/java/org/apache/accumulo/tserver/ 97f2090 
  server/tserver/src/main/java/org/apache/accumulo/tserver/log/ d25ee75

  test/src/test/java/org/apache/accumulo/server/util/ PRE-CREATION

  test/src/test/java/org/apache/accumulo/test/ PRE-CREATION 



Added a new IT.

We insert a few entries to tablets and ensure that the relevant entries appear in the WAL
and Metadata Table.
One test case that isn't included yet is verifying that root + metadata table entries are
entered correctly.


Jonathan Park

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message