Mailing-List: contact dev-help@accumulo.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@accumulo.apache.org
Content-Type: multipart/alternative;
 boundary="===============0504320377910141156=="
MIME-Version: 1.0
Subject: Re: Review Request 24855: ACCUMULO-1454 design doc
From: "Josh Elser" <josh.elser@gmail.com>
To: "accumulo" <dev@accumulo.apache.org>, "Josh Elser" <josh.elser@gmail.com>,
 keith@deenlo.com
Date: Tue, 19 Aug 2014 18:21:58 -0000
Message-ID: <20140819182158.1309.27342@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Josh Elser" <noreply@reviews.apache.org>
References: <20140819175041.1308.8608@reviews.apache.org>
In-Reply-To: <20140819175041.1308.8608@reviews.apache.org>
Reply-To: "Josh Elser" <josh.elser@gmail.com>

--===============0504320377910141156==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24855/#review50998
-----------------------------------------------------------


docs/src/main/asciidoc/design/ACCUMULO-1454-proposal-01.adoc
<https://reviews.apache.org/r/24855/#comment88887>

    More specifics on "have a new config and run on a different port" would be desirable.
    
    On each tserver host, you have tserver1 with conf1. You copy conf1 to conf2, make edits, set ACCUMULO_CONF_DIR in accumulo-env.sh (?), start tserver2 (running with conf2), do whatever tablet migration magic, stop tserver1.
    
    You're now left with tserver2 running on different ports than you started with and different config dirs. Do you then have to go back and modify conf1 to match conf2 (sans the ports) and start tserver1 and stop tserver2? Is there a simpler way to encapsulate this?


docs/src/main/asciidoc/design/ACCUMULO-1454-proposal-01.adoc
<https://reviews.apache.org/r/24855/#comment88878>

    If a user is programming to this API, how do they know what tservers are available? Shouldn't there be a getTabletServers() method as well?
    
    Also, it would be better to return a concrete class instead of Iterable (since we'd likely be backing it by some List). Advertise what we're actaully returning, and let the user treat it as an Iterable if they so choose.


docs/src/main/asciidoc/design/ACCUMULO-1454-proposal-01.adoc
<https://reviews.apache.org/r/24855/#comment88888>

    Does avoiding explicitly providing moveTablet semantics avoid the need for unloadTablets and loadTablets to be FATE ops?


docs/src/main/asciidoc/design/ACCUMULO-1454-proposal-01.adoc
<https://reviews.apache.org/r/24855/#comment88883>

    If you're providing an unloadTablets method, I would think calling loadTablets on a tablet that is already loaded should throw an Exception, not unload it for you.


docs/src/main/asciidoc/design/ACCUMULO-1454-proposal-01.adoc
<https://reviews.apache.org/r/24855/#comment88881>

    I'd lean towards keeping KeyExtent out of user's eyesight.


docs/src/main/asciidoc/design/ACCUMULO-1454-proposal-01.adoc
<https://reviews.apache.org/r/24855/#comment88882>

    These are going to be coming off of a connector or ZKI, right? I would treat the instance id as implied (not required as an argument). host+port sounds good, but how do you distinguish between localhost, 127.0.0.1, the FQDN and the external IP (if there aren't many)?


- Josh Elser


On Aug. 19, 2014, 5:50 p.m., kturner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24855/
> -----------------------------------------------------------
> 
> (Updated Aug. 19, 2014, 5:50 p.m.)
> 
> 
> Review request for accumulo.
> 
> 
> Bugs: ACCUMULO-1454
>     https://issues.apache.org/jira/browse/ACCUMULO-1454
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> Positing ACCUMULO-1454 design doc for review
> 
> 
> Diffs
> -----
> 
>   docs/src/main/asciidoc/design/ACCUMULO-1454-proposal-01.adoc PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/24855/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> kturner
> 
>


--===============0504320377910141156==--