Mailing-List: contact dev-help@accumulo.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@accumulo.apache.org
Content-Type: multipart/alternative;
 boundary="===============3883834287246752450=="
MIME-Version: 1.0
Subject: Re: Review Request 24741: Bug fix for ACCUMULO-1628
From: "Josh Elser" <josh.elser@gmail.com>
To: "accumulo" <dev@accumulo.apache.org>, "Josh Elser" <josh.elser@gmail.com>,
 keith@deenlo.com
Date: Mon, 18 Aug 2014 20:25:37 -0000
Message-ID: <20140818202537.7608.44399@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Josh Elser" <noreply@reviews.apache.org>
References: <20140815163120.4095.85911@reviews.apache.org>
In-Reply-To: <20140815163120.4095.85911@reviews.apache.org>
Reply-To: "Josh Elser" <josh.elser@gmail.com>

--===============3883834287246752450==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24741/#review50931
-----------------------------------------------------------


server/src/test/java/org/apache/accumulo/server/tabletserver/InMemoryMapTest.java
<https://reviews.apache.org/r/24741/#comment88818>

    Probably good to remove the "test" prefix from the method name as it's not a "test" (as per old junit test method definitions; pre @Testannotation), but a helper method


server/src/test/java/org/apache/accumulo/server/tabletserver/InMemoryMapTest.java
<https://reviews.apache.org/r/24741/#comment88817>

    Typo on the method name here.


- Josh Elser


On Aug. 15, 2014, 4:31 p.m., kturner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24741/
> -----------------------------------------------------------
> 
> (Updated Aug. 15, 2014, 4:31 p.m.)
> 
> 
> Review request for accumulo.
> 
> 
> Bugs: ACCUMULO-1628
>     https://issues.apache.org/jira/browse/ACCUMULO-1628
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> Bug fix for ACCUMULO-1628.  If no activity on review by 8/20 I will push patch.
> 
> I was concerned about the case where two threads will concurrently switch different deep copies.   There is the scan thread and the thread deleting in mem map and calling switchNow on each deepCopy.  Access to each deep copy is synchronized, so thats fine.  This patch modified the deep copies to use a shared rfile.  I think deep copy of the shared rfile is synchronized properly.   The shared rfile was introduced to get around problems with the temp file being deleted.  
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/accumulo/core/iterators/system/SourceSwitchingIterator.java a4970dc 
>   server/src/main/java/org/apache/accumulo/server/tabletserver/InMemoryMap.java 914cd85 
>   server/src/test/java/org/apache/accumulo/server/tabletserver/InMemoryMapTest.java 97c8eec 
> 
> Diff: https://reviews.apache.org/r/24741/diff/
> 
> 
> Testing
> -------
> 
> A unit test was added that reproduced the bug.  After changes in patch, unit test no longer reproduces bug.
> 
> mvn package runs w/o a problem
> 
> 
> Thanks,
> 
> kturner
> 
>


--===============3883834287246752450==--