accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ke...@deenlo.com
Subject Re: Review Request 24855: ACCUMULO-1454 design doc
Date Thu, 21 Aug 2014 20:04:37 GMT


> On Aug. 21, 2014, 6:55 p.m., Christopher Tubbs wrote:
> > docs/src/main/asciidoc/design/ACCUMULO-1454-proposal-01.adoc, lines 79-87
> > <https://reviews.apache.org/r/24855/diff/2/?file=665310#file665310line79>
> >
> >     Would these be idempotent, or would there be an error thrown if not in the expected
state? I'd assume idempotent, but it's not clear here.

I was thinking it would continue w/o raising exception if assignments were already enabled.


> On Aug. 21, 2014, 6:55 p.m., Christopher Tubbs wrote:
> > docs/src/main/asciidoc/design/ACCUMULO-1454-proposal-01.adoc, line 100
> > <https://reviews.apache.org/r/24855/diff/2/?file=665310#file665310line100>
> >
> >     We might want to seriously think about how we identify tservers in the API.
String type is probably a bad idea. HostAndPort, or some unique assigned tserverID is probably
better.
> >     
> >     This method could also take a set.

I am going to go w/ String for now, because the existing getTabletServers() and ping() methods
use String.  I think a set is a good idea.


> On Aug. 21, 2014, 6:55 p.m., Christopher Tubbs wrote:
> > docs/src/main/asciidoc/design/ACCUMULO-1454-proposal-01.adoc, line 105
> > <https://reviews.apache.org/r/24855/diff/2/?file=665310#file665310line105>
> >
> >     Would this fail immediately if assignments are disabled? Or hang indefinitely
(maybe with the occasional warning message)?

I think it should fail.  I will add something to the doc.


> On Aug. 21, 2014, 6:55 p.m., Christopher Tubbs wrote:
> > docs/src/main/asciidoc/design/ACCUMULO-1454-proposal-01.adoc, lines 23-24
> > <https://reviews.apache.org/r/24855/diff/2/?file=665310#file665310line23>
> >
> >     I wouldn't want to depend on these specific scripts. I'd expect any actual implementation
would be script-independent and that any restart mechanism for the tserver would be sufficient.

I will add something to the testing section.


- kturner


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24855/#review51201
-----------------------------------------------------------


On Aug. 20, 2014, 5:40 p.m., kturner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24855/
> -----------------------------------------------------------
> 
> (Updated Aug. 20, 2014, 5:40 p.m.)
> 
> 
> Review request for accumulo.
> 
> 
> Bugs: ACCUMULO-1454
>     https://issues.apache.org/jira/browse/ACCUMULO-1454
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> Positing ACCUMULO-1454 design doc for review
> 
> 
> Diffs
> -----
> 
>   docs/src/main/asciidoc/design/ACCUMULO-1454-proposal-01.adoc PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/24855/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> kturner
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message