accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Christopher Tubbs" <ctubbsii...@apache.org>
Subject Re: Review Request 24862: Accumulo-3021 Limit size of split rows
Date Tue, 19 Aug 2014 21:10:09 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24862/#review51034
-----------------------------------------------------------



core/src/main/java/org/apache/accumulo/core/conf/Property.java
<https://reviews.apache.org/r/24862/#comment88910>

    Some other keys have a precedence for "*.size.max"; there are other variations for similar
properties. Not certain which is the best to converge on, but some consistency might help
usability.



core/src/main/java/org/apache/accumulo/core/conf/Property.java
<https://reviews.apache.org/r/24862/#comment88911>

    Good catch.



test/src/test/java/org/apache/accumulo/test/Accumulo3021IT.java
<https://reviews.apache.org/r/24862/#comment88909>

    Recommend changing the name of this test class to something descriptive, like "LargeSplitRowIT"



test/src/test/java/org/apache/accumulo/test/Accumulo3021IT.java
<https://reviews.apache.org/r/24862/#comment88912>

    Document why the sleeps are needed. What condition are we waiting on?



test/src/test/java/org/apache/accumulo/test/Accumulo3021IT.java
<https://reviews.apache.org/r/24862/#comment88913>

    Use StandardCharsets.UTF_8



test/src/test/java/org/apache/accumulo/test/Accumulo3021IT.java
<https://reviews.apache.org/r/24862/#comment88914>

    Use StandardCharsets.UTF_8


- Christopher Tubbs


On Aug. 19, 2014, 4:11 p.m., Jenna Huston wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24862/
> -----------------------------------------------------------
> 
> (Updated Aug. 19, 2014, 4:11 p.m.)
> 
> 
> Review request for accumulo.
> 
> 
> Bugs: Accumulo-3021
>     https://issues.apache.org/jira/browse/Accumulo-3021
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> Added constraint for maximum end row size. Checked this constraint before any split is
done.
> A unit test was added to test the added constraint when both a user initiaed a tablet
split and when an automatic split occurs.  This test also tests to make sure that when new
data is added to a table that is small enough to be used as an end row the table splits.
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/accumulo/core/conf/Property.java 85c56f8 
>   server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Tablet.java 82045b6

>   test/src/test/java/org/apache/accumulo/test/Accumulo3021IT.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/24862/diff/
> 
> 
> Testing
> -------
> 
> Passes unit tests.
> 
> 
> Thanks,
> 
> Jenna Huston
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message