Return-Path: X-Original-To: apmail-accumulo-dev-archive@www.apache.org Delivered-To: apmail-accumulo-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 83B5410B70 for ; Fri, 25 Jul 2014 19:50:30 +0000 (UTC) Received: (qmail 43202 invoked by uid 500); 25 Jul 2014 19:50:30 -0000 Delivered-To: apmail-accumulo-dev-archive@accumulo.apache.org Received: (qmail 43166 invoked by uid 500); 25 Jul 2014 19:50:30 -0000 Mailing-List: contact dev-help@accumulo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@accumulo.apache.org Delivered-To: mailing list dev@accumulo.apache.org Received: (qmail 43145 invoked by uid 99); 25 Jul 2014 19:50:30 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 25 Jul 2014 19:50:30 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 25F541DBAF0; Fri, 25 Jul 2014 19:50:17 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5888103932468154809==" MIME-Version: 1.0 Subject: Re: Review Request 23887: ACCUMULO-3012 - DefaultConfiguration From: "Bill Havanki" To: "Christopher Tubbs" , "Bill Havanki" , "accumulo" , "Josh Elser" Date: Fri, 25 Jul 2014 19:50:17 -0000 Message-ID: <20140725195017.4204.833@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Bill Havanki" X-ReviewGroup: accumulo X-ReviewRequest-URL: https://reviews.apache.org/r/23887/ X-Sender: "Bill Havanki" References: <20140725194750.21500.46288@reviews.apache.org> In-Reply-To: <20140725194750.21500.46288@reviews.apache.org> Reply-To: "Bill Havanki" X-ReviewRequest-Repository: accumulo --===============5888103932468154809== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23887/ ----------------------------------------------------------- (Updated July 25, 2014, 3:50 p.m.) Review request for accumulo. Changes ------- D'oh! Missed a Javadoc change in the last diff. Bugs: ACCUMULO-3012 https://issues.apache.org/jira/browse/ACCUMULO-3012 Repository: accumulo Description ------- * The internal map of resolved (default) properties is now static and immutable, making explicit synchronization unnecessary. * The main method is moved to ConfigurationDocGen. * A unit test is added. * Accompanying changes were made to ConfigSanityCheck: - The validate method takes in an Iterable of entries instead of a Configuration. - Validation failure throws a new CheckException class instead of RuntimeException. - A unit test is added. Diffs (updated) ----- core/src/main/java/org/apache/accumulo/core/conf/ConfigSanityCheck.java f9781f4 core/src/main/java/org/apache/accumulo/core/conf/ConfigurationDocGen.java ca57372 core/src/main/java/org/apache/accumulo/core/conf/DefaultConfiguration.java 44e198a core/src/test/java/org/apache/accumulo/core/conf/ConfigSanityCheckTest.java PRE-CREATION core/src/test/java/org/apache/accumulo/core/conf/DefaultConfigurationTest.java PRE-CREATION docs/pom.xml d54b144 Diff: https://reviews.apache.org/r/23887/diff/ Testing ------- Compiles, unit tests pass, no new findbugs / PMD issues. Thanks, Bill Havanki --===============5888103932468154809==--