Return-Path: X-Original-To: apmail-accumulo-dev-archive@www.apache.org Delivered-To: apmail-accumulo-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id DBC6610A35 for ; Fri, 25 Jul 2014 19:20:15 +0000 (UTC) Received: (qmail 63675 invoked by uid 500); 25 Jul 2014 19:20:15 -0000 Delivered-To: apmail-accumulo-dev-archive@accumulo.apache.org Received: (qmail 63636 invoked by uid 500); 25 Jul 2014 19:20:15 -0000 Mailing-List: contact dev-help@accumulo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@accumulo.apache.org Delivered-To: mailing list dev@accumulo.apache.org Received: (qmail 63611 invoked by uid 99); 25 Jul 2014 19:20:15 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 25 Jul 2014 19:20:15 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 7467D1DBAF0; Fri, 25 Jul 2014 19:20:02 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============9198981380552583567==" MIME-Version: 1.0 Subject: Re: Review Request 23887: ACCUMULO-3012 - DefaultConfiguration From: "Christopher Tubbs" To: "Bill Havanki" , "Christopher Tubbs" , "accumulo" Date: Fri, 25 Jul 2014 19:20:02 -0000 Message-ID: <20140725192002.4204.40848@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Christopher Tubbs" X-ReviewGroup: accumulo X-ReviewRequest-URL: https://reviews.apache.org/r/23887/ X-Sender: "Christopher Tubbs" References: <20140725170810.4204.56148@reviews.apache.org> In-Reply-To: <20140725170810.4204.56148@reviews.apache.org> Reply-To: "Christopher Tubbs" X-ReviewRequest-Repository: accumulo --===============9198981380552583567== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23887/#review48757 ----------------------------------------------------------- Mostly looks good. Small exception rename suggestion. core/src/main/java/org/apache/accumulo/core/conf/ConfigSanityCheck.java Can we call this SanityCheckException? (CheckException is too generic, and intuitively seems to have something to do with "checked exceptions", which isn't the case.) - Christopher Tubbs On July 25, 2014, 1:08 p.m., Bill Havanki wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23887/ > ----------------------------------------------------------- > > (Updated July 25, 2014, 1:08 p.m.) > > > Review request for accumulo. > > > Bugs: ACCUMULO-3012 > https://issues.apache.org/jira/browse/ACCUMULO-3012 > > > Repository: accumulo > > > Description > ------- > > * The internal map of resolved (default) properties is now static and immutable, making explicit synchronization unnecessary. > * The main method is moved to ConfigurationDocGen. > * A unit test is added. > * Accompanying changes were made to ConfigSanityCheck: > - The validate method takes in an Iterable of entries instead of a Configuration. > - Validation failure throws a new CheckException class instead of RuntimeException. > - A unit test is added. > > > Diffs > ----- > > core/src/main/java/org/apache/accumulo/core/conf/ConfigSanityCheck.java f9781f4 > core/src/main/java/org/apache/accumulo/core/conf/ConfigurationDocGen.java ca57372 > core/src/main/java/org/apache/accumulo/core/conf/DefaultConfiguration.java 44e198a > core/src/test/java/org/apache/accumulo/core/conf/ConfigSanityCheckTest.java PRE-CREATION > core/src/test/java/org/apache/accumulo/core/conf/DefaultConfigurationTest.java PRE-CREATION > docs/pom.xml d54b144 > > Diff: https://reviews.apache.org/r/23887/diff/ > > > Testing > ------- > > Compiles, unit tests pass, no new findbugs / PMD issues. > > > Thanks, > > Bill Havanki > > --===============9198981380552583567==--