Mailing-List: contact dev-help@accumulo.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@accumulo.apache.org
Content-Type: multipart/alternative;
 boundary="===============7809019182392279600=="
MIME-Version: 1.0
Subject: Re: Review Request 23391: ACCUMULO-2986 ease use of rat plugin.
From: "Sean Busbey" <sean@manvsbeard.com>
To: "Mike Drob" <mdrob@mdrob.com>, "Sean Busbey" <sean@manvsbeard.com>,
 "accumulo" <dev@accumulo.apache.org>,
 "Bill Havanki" <bhavanki@clouderagovt.com>
Date: Thu, 10 Jul 2014 21:03:56 -0000
Message-ID: <20140710210356.17972.97428@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Sean Busbey" <noreply@reviews.apache.org>
References: <20140710122801.17970.23096@reviews.apache.org>
In-Reply-To: <20140710122801.17970.23096@reviews.apache.org>
Reply-To: "Sean Busbey" <sean@manvsbeard.com>

--===============7809019182392279600==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit


> On July 10, 2014, 12:28 p.m., Mike Drob wrote:
> > pom.xml, lines 1040-1064
> > <https://reviews.apache.org/r/23391/diff/1/?file=627668#file627668line1040>
> >
> >     It is unclear to me when this profile is activated. Nominally, I see that it would be if the rat.skip property is not set, but does the user have any way to unset it, given that it is declared earlier in the file?
> 
> Sean Busbey wrote:
>     it's activated when the user doesn't say anything one way or another. having rat.skip defined in the pom properties is for clarity, it can't activate a profile.
> 
> Bill Havanki wrote:
>     Does it need to be there to make the true/false property check pass when the user doesn't specify it? (Can the check say it's an optional property?) If it doesn't do anything useful, I'd replace it with a comment.
> 
> Sean Busbey wrote:
>     You're right Bill, it does need to be present because of hte enforcer check. I'll see if there's an enforcer "optional property"

Enforcer has no notion of a property that must have certain values, but only if it's set at all.


- Sean


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23391/#review47561
-----------------------------------------------------------


On July 10, 2014, 8:34 a.m., Sean Busbey wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23391/
> -----------------------------------------------------------
> 
> (Updated July 10, 2014, 8:34 a.m.)
> 
> 
> Review request for accumulo.
> 
> 
> Bugs: ACCUMULO-2986
>     https://issues.apache.org/jira/browse/ACCUMULO-2986
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> * puts rat plugin into profile
> * activates profile by default
> * ignores rat errrors by default
> 
> 
> Diffs
> -----
> 
>   pom.xml 2bc87cf082dfeb7bfe1a3fac1fe4fba1eaa87edd 
> 
> Diff: https://reviews.apache.org/r/23391/diff/
> 
> 
> Testing
> -------
> 
> verified rat warnings and failures given move from master -> 1.6.1-SNAPSHOT branch with no definitions, -Drat.skip=true, -Drat.skip=false, -Drat.ignoreErrors=true, and profile to check errors in ~/.m2/settings.xml
> 
> 
> Thanks,
> 
> Sean Busbey
> 
>


--===============7809019182392279600==--