Return-Path: X-Original-To: apmail-accumulo-dev-archive@www.apache.org Delivered-To: apmail-accumulo-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 0D8A411DB0 for ; Thu, 10 Jul 2014 17:50:33 +0000 (UTC) Received: (qmail 45927 invoked by uid 500); 10 Jul 2014 17:50:32 -0000 Delivered-To: apmail-accumulo-dev-archive@accumulo.apache.org Received: (qmail 45885 invoked by uid 500); 10 Jul 2014 17:50:32 -0000 Mailing-List: contact dev-help@accumulo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@accumulo.apache.org Delivered-To: mailing list dev@accumulo.apache.org Received: (qmail 45869 invoked by uid 99); 10 Jul 2014 17:50:32 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 10 Jul 2014 17:50:32 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 89CC01DB64E; Thu, 10 Jul 2014 17:50:19 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1915389940996593887==" MIME-Version: 1.0 Subject: Re: Review Request 23397: ACCUMULO-2984 Support Running MAC against a standard instance From: "Sean Busbey" To: "John Vines" , "Sean Busbey" , "accumulo" Date: Thu, 10 Jul 2014 17:50:18 -0000 Message-ID: <20140710175018.17971.15642@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Sean Busbey" X-ReviewGroup: accumulo X-ReviewRequest-URL: https://reviews.apache.org/r/23397/ X-Sender: "Sean Busbey" References: <20140710172442.17971.62922@reviews.apache.org> In-Reply-To: <20140710172442.17971.62922@reviews.apache.org> Reply-To: "Sean Busbey" X-ReviewRequest-Repository: accumulo --===============1915389940996593887== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23397/#review47585 ----------------------------------------------------------- I don't see a check to ensure that the MAC isn't getting started against an existing instance while that instance is still running. Can you please add one? Something similar to what the offline tools use should suffice. core/src/main/java/org/apache/accumulo/core/conf/SiteConfiguration.java add a javadoc please. minicluster/src/main/java/org/apache/accumulo/minicluster/MiniAccumuloConfig.java nit: whitesapce minicluster/src/main/java/org/apache/accumulo/minicluster/MiniAccumuloConfig.java nit whitespace minicluster/src/main/java/org/apache/accumulo/minicluster/impl/MiniAccumuloClusterImpl.java nit: can we skip this change in line wrapping? I think this change set is already likely to conflict with ACCUMULO-2944 and I'd like to minimize it. minicluster/src/main/java/org/apache/accumulo/minicluster/impl/MiniAccumuloClusterImpl.java nit: can we skip this line wrap change? I'm pretty sure this is going to conflict with ACCUMULO-2944 and I'd like to minimize it. minicluster/src/main/java/org/apache/accumulo/minicluster/impl/MiniAccumuloConfigImpl.java nit: whitespace minicluster/src/main/java/org/apache/accumulo/minicluster/impl/MiniAccumuloConfigImpl.java nit: whitespace minicluster/src/main/java/org/apache/accumulo/minicluster/impl/MiniAccumuloConfigImpl.java nit: whitespace minicluster/src/main/java/org/apache/accumulo/minicluster/impl/MiniAccumuloConfigImpl.java nit: whitespace minicluster/src/main/java/org/apache/accumulo/minicluster/impl/MiniAccumuloConfigImpl.java nit: whitespace - Sean Busbey On July 10, 2014, 5:24 p.m., John Vines wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23397/ > ----------------------------------------------------------- > > (Updated July 10, 2014, 5:24 p.m.) > > > Review request for accumulo. > > > Bugs: ACCUMULO-2984 > https://issues.apache.org/jira/browse/ACCUMULO-2984 > > > Repository: accumulo > > > Description > ------- > > Adds a change to SiteConfiguration to allow external setting of the xml configuration file. > Adds a single method to MiniAccumuloConfig which allows a user to point to accumulo-site.xml and HADOOP_CONF_DIR to use for pulling out requisite instance information > Clusters configurations into those required to run inside a MAC-sized footprint and those which are for arbitrary naming schemes for MAC > Provides flagging to prevent uneccessary folder creation > Provides flagging to prevent running zookeeper and initializing > > > Diffs > ----- > > core/src/main/java/org/apache/accumulo/core/conf/SiteConfiguration.java 4c7d95e > minicluster/src/main/java/org/apache/accumulo/minicluster/MiniAccumuloConfig.java be80f85 > minicluster/src/main/java/org/apache/accumulo/minicluster/impl/MiniAccumuloClusterImpl.java 977968e > minicluster/src/main/java/org/apache/accumulo/minicluster/impl/MiniAccumuloConfigImpl.java 337eda0 > > Diff: https://reviews.apache.org/r/23397/diff/ > > > Testing > ------- > > Ran the following test code- > public class TestMACWithRealInstance { > public static void main(String args[]) throws IOException, AccumuloException, AccumuloSecurityException, TableExistsException, InterruptedException { > MiniAccumuloConfig macConfig = new MiniAccumuloConfig(new File("/tmp/mac"), "secret"); > macConfig.setNumTservers(2); > macConfig.setMemory(ServerType.TABLET_SERVER, 2, MemoryUnit.GIGABYTE); > macConfig.useExistingInstance(new File("/usr/lib/accumulo/conf/accumulo-site.xml"), new File("/usr/lib/hadoop/conf")); > MiniAccumuloCluster mac = new MiniAccumuloCluster(macConfig); > mac.start(); > System.out.println("Started"); > mac.getConnector("root", "secret").tableOperations().create("macCreated"); > System.out.println("Stopping"); > mac.stop(); > System.out.println("Stopped"); > } > } > Which runs fine, except stopping issues which seem to be related to ACCUMULO-2985 > > After running this, I validated that the table was created in the real accumulo instance via zkCli > > > Thanks, > > John Vines > > --===============1915389940996593887==--