Mailing-List: contact dev-help@accumulo.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@accumulo.apache.org
Content-Type: multipart/alternative;
 boundary="===============7288519944462620384=="
MIME-Version: 1.0
Subject: Re: Review Request 23093: ACCUMULO-2947 - Limit cells per mutation in
 memory
 stress test
From: "Bill Havanki" <bhavanki@clouderagovt.com>
To: "Bill Slacum" <ujustgotbilld@apache.org>
Cc: "Bill Havanki" <bhavanki@clouderagovt.com>,
 "accumulo" <dev@accumulo.apache.org>, "Josh Elser" <josh.elser@gmail.com>
Date: Tue, 01 Jul 2014 19:01:25 -0000
Message-ID: <20140701190125.5201.54908@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Bill Havanki" <noreply@reviews.apache.org>
References: <20140701174314.5196.60540@reviews.apache.org>
In-Reply-To: <20140701174314.5196.60540@reviews.apache.org>
Reply-To: "Bill Havanki" <bhavanki@clouderagovt.com>

--===============7288519944462620384==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit


> On July 1, 2014, 1:43 p.m., Josh Elser wrote:
> > test/system/stress/stress-env.sh.example, line 55
> > <https://reviews.apache.org/r/23093/diff/3/?file=621403#file621403line55>
> >
> >     Would be nice to include what the default -1 value equates to in the comment (in addition to the help message) since you have a nice comment describing the argument already.

Good deal.


- Bill


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23093/#review47105
-----------------------------------------------------------


On July 1, 2014, 3 p.m., Bill Havanki wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23093/
> -----------------------------------------------------------
> 
> (Updated July 1, 2014, 3 p.m.)
> 
> 
> Review request for accumulo and Bill Slacum.
> 
> 
> Bugs: ACCUMULO-2947
>     https://issues.apache.org/jira/browse/ACCUMULO-2947
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> A new switch to the memory stress test Write utility, --max-cells-per-mutation, controls the maximum number of cells to be written in any mutation. If the maximum is hit before the configured row width, the current mutation is used and the next mutation picks up where it left off, in the same row.
> 
> The core logic is in the RandomMutations class. It uses a counter for how many cells are remaining in the current row, with 0 indicating that a new row should be started. Otherwise, the last row is used. The counter is used as the loop counter for writing cells. When it hits zero or the maximum, writes stop.
> 
> 
> Diffs
> -----
> 
>   test/src/main/java/org/apache/accumulo/test/stress/random/RandomMutations.java c4504b2 
>   test/src/main/java/org/apache/accumulo/test/stress/random/Write.java 9c29871 
>   test/src/main/java/org/apache/accumulo/test/stress/random/WriteOptions.java c213528 
>   test/system/stress/stress-env.sh.example 1360c67 
>   test/system/stress/writer.sh 7d9b283 
> 
> Diff: https://reviews.apache.org/r/23093/diff/
> 
> 
> Testing
> -------
> 
> Ran memory stress test on single-node 1.5.2 cluster. With max-cells-per-mutation = 4 and row-width ranging from 1 to 7, saw rows still being written with 5 or more cells.
> 
> 
> Thanks,
> 
> Bill Havanki
> 
>


--===============7288519944462620384==--