accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sean Busbey" <s...@manvsbeard.com>
Subject Re: Review Request 23959: ACCUMULO-2694 Changes for 1.6 branch
Date Mon, 28 Jul 2014 16:01:26 GMT


> On July 28, 2014, 3:18 p.m., Josh Elser wrote:
> > test/src/test/java/org/apache/accumulo/test/functional/BalanceInPresenceOfOfflineTableIT.java,
line 108
> > <https://reviews.apache.org/r/23959/diff/2/?file=642687#file642687line108>
> >
> >     Created ACCUMULO-3027 because this is horrible to have to idle wait for 5+ mins.
> >     
> >     Can we do something more "responsive" (sleep 15s, check state, if fail, loop,
otherwise pass) until we get the fix in place?

Sure, that should be doable. Do you want to see that same fix back in the 1.5 functional test?


- Sean


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23959/#review48851
-----------------------------------------------------------


On July 26, 2014, 1:05 a.m., Sean Busbey wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23959/
> -----------------------------------------------------------
> 
> (Updated July 26, 2014, 1:05 a.m.)
> 
> 
> Review request for accumulo and Josh Elser.
> 
> 
> Bugs: ACCUMULO-2694
>     https://issues.apache.org/jira/browse/ACCUMULO-2694
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> These are the changes needed on 1.6 after merging the fix for the 1.5 branch forward.
> 
>     - manually redo changes to Master
>     - convert python functional test to an IT
>     -- Add programmatic access to MasterMonitorInfo to MiniAccumuloClusterImpl
>     -- Make SystemCredentials work with MiniAccumuloClusterImpl
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/accumulo/core/client/AccumuloSecurityException.java 06b148d79fa6f97aedff115ad21d7459f17567f6

>   minicluster/src/main/java/org/apache/accumulo/minicluster/impl/MiniAccumuloClusterImpl.java
977968ec3da356b9e3f3e6aa3a9fe3d7bf36ac46 
>   minicluster/src/test/java/org/apache/accumulo/minicluster/impl/MiniAccumuloClusterImplTest.java
99f8d7d62b687dd8c9ccbb7f0879885ad3a8cf39 
>   minicluster/src/test/resources/log4j.properties b5efe8d6e29d14d4044c9b60c800f0e9d7cc85b3

>   server/base/src/main/java/org/apache/accumulo/server/security/SystemCredentials.java
767ed2589000e60bae63c106834b2493a7f39404 
>   server/master/src/main/java/org/apache/accumulo/master/Master.java 797e06656a800cc9e3c4a1959b8b25a85768fc9e

>   test/pom.xml f3cc927c6cc724450109a7baa6a96b3278c3f86b 
>   test/src/test/java/org/apache/accumulo/test/functional/BalanceInPresenceOfOfflineTableIT.java
PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/23959/diff/
> 
> 
> Testing
> -------
> 
> Ran new IT prior to Master changes: test fails; ran new IT after Master changes: test
passes.
> 
> 
> Thanks,
> 
> Sean Busbey
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message