accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Havanki" <bhava...@clouderagovt.com>
Subject Re: Review Request 23933: ACCUMULO-3012 - DefaultConfiguration (1.5)
Date Fri, 25 Jul 2014 19:52:57 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23933/
-----------------------------------------------------------

(Updated July 25, 2014, 3:52 p.m.)


Review request for accumulo and Josh Elser.


Changes
-------

Renamed CheckException to SanityCheckException.


Summary (updated)
-----------------

ACCUMULO-3012 - DefaultConfiguration (1.5)


Bugs: ACCUMULO-3012
    https://issues.apache.org/jira/browse/ACCUMULO-3012


Repository: accumulo


Description
-------

A similar change to the one posted for review #23887, but adapted for 1.5.2-SNAPSHOT at Josh's
request. The changes were significant enough that a separate review is warranted.

* The map of default properties created during the iterator() method each time is now static
and immutable.
* A unit test is added.
* Accompanying changes were made to ConfigSanityCheck:
  - The validate method takes in an Iterable of entries instead of a Configuration.
  - Validation failure throws a new CheckException class instead of RuntimeException.
  - A unit test is added.


Diffs (updated)
-----

  core/src/main/java/org/apache/accumulo/core/conf/ConfigSanityCheck.java 6724670 
  core/src/main/java/org/apache/accumulo/core/conf/DefaultConfiguration.java d653274 
  core/src/test/java/org/apache/accumulo/core/conf/ConfigSanityCheckTest.java PRE-CREATION

  core/src/test/java/org/apache/accumulo/core/conf/DefaultConfigurationTest.java PRE-CREATION


Diff: https://reviews.apache.org/r/23933/diff/


Testing
-------

Compiles, unit tests pass.


Thanks,

Bill Havanki


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message