accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Havanki" <>
Subject Re: Review Request 23887: ACCUMULO-3012 - DefaultConfiguration
Date Fri, 25 Jul 2014 19:50:17 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated July 25, 2014, 3:50 p.m.)

Review request for accumulo.


D'oh! Missed a Javadoc change in the last diff.

Bugs: ACCUMULO-3012

Repository: accumulo


* The internal map of resolved (default) properties is now static and immutable, making explicit
synchronization unnecessary.
* The main method is moved to ConfigurationDocGen.
* A unit test is added.
* Accompanying changes were made to ConfigSanityCheck:
  - The validate method takes in an Iterable of entries instead of a Configuration.
  - Validation failure throws a new CheckException class instead of RuntimeException.
  - A unit test is added.

Diffs (updated)

  core/src/main/java/org/apache/accumulo/core/conf/ f9781f4 
  core/src/main/java/org/apache/accumulo/core/conf/ ca57372 
  core/src/main/java/org/apache/accumulo/core/conf/ 44e198a 
  core/src/test/java/org/apache/accumulo/core/conf/ PRE-CREATION

  core/src/test/java/org/apache/accumulo/core/conf/ PRE-CREATION

  docs/pom.xml d54b144 



Compiles, unit tests pass, no new findbugs / PMD issues.


Bill Havanki

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message