accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Josh Elser" <josh.el...@gmail.com>
Subject Re: Review Request 23887: ACCUMULO-3012 - DefaultConfiguration
Date Fri, 25 Jul 2014 17:10:56 GMT


> On July 25, 2014, 3:33 p.m., Josh Elser wrote:
> > core/src/main/java/org/apache/accumulo/core/conf/ConfigurationDocGen.java, line
346
> > <https://reviews.apache.org/r/23887/diff/2/?file=641344#file641344line346>
> >
> >     Moving this from DefaultConfiguration to ConfigurationDocGen breaks the exec-maven-plugin
invocation in docs/pom.xml.
> >     
> >     Moving the main method probably won't give users headaches? I'm not sure. I
can't think of a reason that users would use this themselves, but I've been fooled more than
once by users doing unexpected things.
> 
> Bill Havanki wrote:
>     Good catch, I've never tried that sort of build before.

Those options caught my eye and made me think "HEY, I've seen those somewhere before" :)


- Josh


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23887/#review48736
-----------------------------------------------------------


On July 25, 2014, 5:08 p.m., Bill Havanki wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23887/
> -----------------------------------------------------------
> 
> (Updated July 25, 2014, 5:08 p.m.)
> 
> 
> Review request for accumulo.
> 
> 
> Bugs: ACCUMULO-3012
>     https://issues.apache.org/jira/browse/ACCUMULO-3012
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> * The internal map of resolved (default) properties is now static and immutable, making
explicit synchronization unnecessary.
> * The main method is moved to ConfigurationDocGen.
> * A unit test is added.
> * Accompanying changes were made to ConfigSanityCheck:
>   - The validate method takes in an Iterable of entries instead of a Configuration.
>   - Validation failure throws a new CheckException class instead of RuntimeException.
>   - A unit test is added.
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/accumulo/core/conf/ConfigSanityCheck.java f9781f4 
>   core/src/main/java/org/apache/accumulo/core/conf/ConfigurationDocGen.java ca57372 
>   core/src/main/java/org/apache/accumulo/core/conf/DefaultConfiguration.java 44e198a

>   core/src/test/java/org/apache/accumulo/core/conf/ConfigSanityCheckTest.java PRE-CREATION

>   core/src/test/java/org/apache/accumulo/core/conf/DefaultConfigurationTest.java PRE-CREATION

>   docs/pom.xml d54b144 
> 
> Diff: https://reviews.apache.org/r/23887/diff/
> 
> 
> Testing
> -------
> 
> Compiles, unit tests pass, no new findbugs / PMD issues.
> 
> 
> Thanks,
> 
> Bill Havanki
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message