accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Havanki" <bhava...@clouderagovt.com>
Subject Re: Review Request 23887: ACCUMULO-3012 - DefaultConfiguration
Date Thu, 24 Jul 2014 14:52:56 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23887/
-----------------------------------------------------------

(Updated July 24, 2014, 10:52 a.m.)


Review request for accumulo.


Changes
-------

Fixed imports in unit tests.


Bugs: ACCUMULO-3012
    https://issues.apache.org/jira/browse/ACCUMULO-3012


Repository: accumulo


Description
-------

* The internal map of resolved (default) properties is now static and immutable, making explicit
synchronization unnecessary.
* The main method is moved to ConfigurationDocGen.
* A unit test is added.
* Accompanying changes were made to ConfigSanityCheck:
  - The validate method takes in an Iterable of entries instead of a Configuration.
  - Validation failure throws a new CheckException class instead of RuntimeException.
  - A unit test is added.


Diffs (updated)
-----

  core/src/main/java/org/apache/accumulo/core/conf/ConfigSanityCheck.java f9781f4 
  core/src/main/java/org/apache/accumulo/core/conf/ConfigurationDocGen.java ca57372 
  core/src/main/java/org/apache/accumulo/core/conf/DefaultConfiguration.java 44e198a 
  core/src/test/java/org/apache/accumulo/core/conf/ConfigSanityCheckTest.java PRE-CREATION

  core/src/test/java/org/apache/accumulo/core/conf/DefaultConfigurationTest.java PRE-CREATION


Diff: https://reviews.apache.org/r/23887/diff/


Testing
-------

Compiles, unit tests pass, no new findbugs / PMD issues.


Thanks,

Bill Havanki


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message