accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Eric Newton" <eric.new...@gmail.com>
Subject Re: Review Request 23458: ACCUMULO-2992 - no more AccumuloConfiguration.getSiteConfiguration
Date Mon, 14 Jul 2014 21:50:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23458/#review47740
-----------------------------------------------------------

Ship it!


Ship It!

- Eric Newton


On July 14, 2014, 8:10 p.m., Bill Havanki wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23458/
> -----------------------------------------------------------
> 
> (Updated July 14, 2014, 8:10 p.m.)
> 
> 
> Review request for accumulo.
> 
> 
> Bugs: ACCUMULO-2992
>     https://issues.apache.org/jira/browse/ACCUMULO-2992
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> Pretty straightforward removal of the long-deprecated static method AccumuloConfiguration.getSiteConfiguration().
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/accumulo/core/conf/AccumuloConfiguration.java 6d20cb0

>   core/src/main/java/org/apache/accumulo/core/file/rfile/PrintInfo.java dc54b49 
>   core/src/main/java/org/apache/accumulo/core/file/rfile/bcfile/PrintInfo.java f387cc2

>   core/src/main/java/org/apache/accumulo/core/util/shell/commands/FateCommand.java 0196baf

>   test/src/test/java/org/apache/accumulo/test/util/CertUtils.java b561600 
> 
> Diff: https://reviews.apache.org/r/23458/diff/
> 
> 
> Testing
> -------
> 
> Compiles, unit tests pass (including CertUtilsTest which was modified in the patch).
> 
> 
> Thanks,
> 
> Bill Havanki
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message