accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Vines" <vi...@apache.org>
Subject Re: Review Request 23397: ACCUMULO-2984 Support Running MAC against a standard instance
Date Thu, 10 Jul 2014 22:48:01 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23397/
-----------------------------------------------------------

(Updated July 10, 2014, 10:48 p.m.)


Review request for accumulo.


Changes
-------

Revised file with attempts to check to see if accumulo is already running, as well as fixes
to javadoc whitespaces in altered files (so others don't make my mistake from copy/pasting)


Bugs: ACCUMULO-2984
    https://issues.apache.org/jira/browse/ACCUMULO-2984


Repository: accumulo


Description
-------

Adds a change to SiteConfiguration to allow external setting of the xml configuration file.
Adds a single method to MiniAccumuloConfig which allows a user to point to accumulo-site.xml
and HADOOP_CONF_DIR to use for pulling out requisite instance information
Clusters configurations into those required to run inside a MAC-sized footprint and those
which are for arbitrary naming schemes for MAC
Provides flagging to prevent uneccessary folder creation
Provides flagging to prevent running zookeeper and initializing


Diffs (updated)
-----

  core/src/main/java/org/apache/accumulo/core/conf/SiteConfiguration.java 4c7d95e 
  minicluster/src/main/java/org/apache/accumulo/minicluster/MiniAccumuloCluster.java 50bb14a

  minicluster/src/main/java/org/apache/accumulo/minicluster/MiniAccumuloConfig.java be80f85

  minicluster/src/main/java/org/apache/accumulo/minicluster/impl/MiniAccumuloClusterImpl.java
977968e 
  minicluster/src/main/java/org/apache/accumulo/minicluster/impl/MiniAccumuloConfigImpl.java
337eda0 
  server/base/src/main/java/org/apache/accumulo/server/util/AccumuloStatus.java PRE-CREATION


Diff: https://reviews.apache.org/r/23397/diff/


Testing
-------

Ran the following test code-
public class TestMACWithRealInstance {
  public static void main(String args[]) throws IOException, AccumuloException, AccumuloSecurityException,
TableExistsException, InterruptedException {
    MiniAccumuloConfig macConfig = new MiniAccumuloConfig(new File("/tmp/mac"), "secret");
    macConfig.setNumTservers(2);
    macConfig.setMemory(ServerType.TABLET_SERVER, 2, MemoryUnit.GIGABYTE);
    macConfig.useExistingInstance(new File("/usr/lib/accumulo/conf/accumulo-site.xml"), new
File("/usr/lib/hadoop/conf"));
    MiniAccumuloCluster mac = new MiniAccumuloCluster(macConfig);
    mac.start();
    System.out.println("Started");
    mac.getConnector("root", "secret").tableOperations().create("macCreated");
    System.out.println("Stopping");
    mac.stop();
    System.out.println("Stopped");
  }
}
Which runs fine, except stopping issues which seem to be related to ACCUMULO-2985

After running this, I validated that the table was created in the real accumulo instance via
zkCli


Thanks,

John Vines


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message