accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mike Drob" <md...@mdrob.com>
Subject Re: Review Request 23391: ACCUMULO-2986 ease use of rat plugin.
Date Thu, 10 Jul 2014 12:28:01 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23391/#review47561
-----------------------------------------------------------



pom.xml
<https://reviews.apache.org/r/23391/#comment83568>

    Too pedantic. Do other maven properties operate on strict true/false values?



pom.xml
<https://reviews.apache.org/r/23391/#comment83567>

    It is unclear to me when this profile is activated. Nominally, I see that it would be
if the rat.skip property is not set, but does the user have any way to unset it, given that
it is declared earlier in the file?


- Mike Drob


On July 10, 2014, 8:34 a.m., Sean Busbey wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23391/
> -----------------------------------------------------------
> 
> (Updated July 10, 2014, 8:34 a.m.)
> 
> 
> Review request for accumulo.
> 
> 
> Bugs: ACCUMULO-2986
>     https://issues.apache.org/jira/browse/ACCUMULO-2986
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> * puts rat plugin into profile
> * activates profile by default
> * ignores rat errrors by default
> 
> 
> Diffs
> -----
> 
>   pom.xml 2bc87cf082dfeb7bfe1a3fac1fe4fba1eaa87edd 
> 
> Diff: https://reviews.apache.org/r/23391/diff/
> 
> 
> Testing
> -------
> 
> verified rat warnings and failures given move from master -> 1.6.1-SNAPSHOT branch
with no definitions, -Drat.skip=true, -Drat.skip=false, -Drat.ignoreErrors=true, and profile
to check errors in ~/.m2/settings.xml
> 
> 
> Thanks,
> 
> Sean Busbey
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message