accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From haydenmarchant <...@git.apache.org>
Subject [GitHub] accumulo pull request: ACCUMULO-2944 Fixes harded coded Sun JVM in...
Date Wed, 09 Jul 2014 07:19:31 GMT
Github user haydenmarchant commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/9#discussion_r14696336
  
    --- Diff: minicluster/src/main/java/org/apache/accumulo/minicluster/impl/MiniAccumuloClusterImpl.java
---
    @@ -259,7 +259,14 @@ private Process _exec(Class<?> clazz, List<String> extraJvmOpts,
String... args)
         for (Entry<String,String> sysProp : config.getSystemProperties().entrySet())
{
           argList.add(String.format("-D%s=%s", sysProp.getKey(), sysProp.getValue()));
         }
    -    argList.addAll(Arrays.asList("-XX:+UseConcMarkSweepGC", "-XX:CMSInitiatingOccupancyFraction=75",
"-Dapple.awt.UIElement=true", Main.class.getName(), className));
    +    
    +    String gcPolicyArgs = System.getenv("GC_POLICY_ARGS");
    --- End diff --
    
    Since I am not so familiar with maven, my assumption was that a user would manually change
the pom to 'inject' the JVM-vendor. If we can automate this by profiles, that makes a lot
of sense. I take it that it doesn't change this patch, but rather would be on top of this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message