accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From busbey <...@git.apache.org>
Subject [GitHub] accumulo pull request: ACCUMULO-2944 Fixes harded coded Sun JVM in...
Date Wed, 09 Jul 2014 07:07:48 GMT
Github user busbey commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/9#discussion_r14696044
  
    --- Diff: minicluster/src/main/java/org/apache/accumulo/minicluster/impl/MiniAccumuloClusterImpl.java
---
    @@ -259,7 +259,14 @@ private Process _exec(Class<?> clazz, List<String> extraJvmOpts,
String... args)
         for (Entry<String,String> sysProp : config.getSystemProperties().entrySet())
{
           argList.add(String.format("-D%s=%s", sysProp.getKey(), sysProp.getValue()));
         }
    -    argList.addAll(Arrays.asList("-XX:+UseConcMarkSweepGC", "-XX:CMSInitiatingOccupancyFraction=75",
"-Dapple.awt.UIElement=true", Main.class.getName(), className));
    +    
    +    String gcPolicyArgs = System.getenv("GC_POLICY_ARGS");
    --- End diff --
    
    For this to impact the current MAC uses in the ITs, won't we need to have this env variable
set? should we be adding jvm-vendor activated profiles to the pom?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message