accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sean Busbey" <s...@manvsbeard.com>
Subject Re: Review Request 23200: ACCUMULO-2967 Unknown Host should result in timeout.
Date Tue, 01 Jul 2014 17:05:29 GMT


> On July 1, 2014, 5:01 p.m., Bill Havanki wrote:
> > fate/src/main/java/org/apache/accumulo/fate/zookeeper/ZooSession.java, line 119
> > <https://reviews.apache.org/r/23200/diff/2/?file=621394#file621394line119>
> >
> >     If the ZK object is successfully created and connected, the timeout check can
still throw an exception. The if check here should also see if tryAgain is true.

That's what it originally did prior to any changes. I presumed it was intentional.


- Sean


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23200/#review47094
-----------------------------------------------------------


On July 1, 2014, 4:55 p.m., Sean Busbey wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23200/
> -----------------------------------------------------------
> 
> (Updated July 1, 2014, 4:55 p.m.)
> 
> 
> Review request for accumulo and Mike Drob.
> 
> 
> Bugs: ACCUMULO-2967
>     https://issues.apache.org/jira/browse/ACCUMULO-2967
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> - Tests that we get an exception within a reasonable bound
> - Changes timeout condition to check prior to place where an exception can be thrown.
> 
> 
> Diffs
> -----
> 
>   fate/src/main/java/org/apache/accumulo/fate/zookeeper/ZooSession.java 205ff01809141f4fcabf860dbb93469207ac2842

>   fate/src/test/java/org/apache/accumulo/fate/zookeeper/ZooSessionTest.java PRE-CREATION

> 
> Diff: https://reviews.apache.org/r/23200/diff/
> 
> 
> Testing
> -------
> 
> prior to change, given test fails on timeout (tested up to a 5 minute wait). post change
test passes.
> 
> 
> Thanks,
> 
> Sean Busbey
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message