accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Josh Elser" <josh.el...@gmail.com>
Subject Re: Review Request 23200: ACCUMULO-2967 Unknown Host should result in timeout.
Date Tue, 01 Jul 2014 16:45:00 GMT


> On July 1, 2014, 4:32 p.m., Josh Elser wrote:
> > fate/src/main/java/org/apache/accumulo/fate/zookeeper/ZooSession.java, line 88
> > <https://reviews.apache.org/r/23200/diff/1/?file=621351#file621351line88>
> >
> >     Would be nice if we could skip this check on the first iteration.
> 
> Sean Busbey wrote:
>     We almost certainly won't have passed the timeout interval, why add the extra state
tracking?

To the same argument, why call to get the time again when we almost certainly haven't passed
the timeout interval?


- Josh


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23200/#review47081
-----------------------------------------------------------


On July 1, 2014, 4:23 p.m., Sean Busbey wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23200/
> -----------------------------------------------------------
> 
> (Updated July 1, 2014, 4:23 p.m.)
> 
> 
> Review request for accumulo and Mike Drob.
> 
> 
> Bugs: ACCUMULO-2967
>     https://issues.apache.org/jira/browse/ACCUMULO-2967
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> - Tests that we get an exception within a reasonable bound
> - Changes timeout condition to check prior to place where an exception can be thrown.
> 
> 
> Diffs
> -----
> 
>   fate/src/main/java/org/apache/accumulo/fate/zookeeper/ZooSession.java 205ff01809141f4fcabf860dbb93469207ac2842

>   fate/src/test/java/org/apache/accumulo/fate/zookeeper/ZooSessionTest.java PRE-CREATION

> 
> Diff: https://reviews.apache.org/r/23200/diff/
> 
> 
> Testing
> -------
> 
> prior to change, given test fails on timeout (tested up to a 5 minute wait). post change
test passes.
> 
> 
> Thanks,
> 
> Sean Busbey
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message