accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Havanki" <bhava...@clouderagovt.com>
Subject Re: Review Request 23093: ACCUMULO-2947 - Limit cells per mutation in memory stress test
Date Tue, 01 Jul 2014 16:39:23 GMT


> On June 30, 2014, 4:05 p.m., Mike Drob wrote:
> > test/src/main/java/org/apache/accumulo/test/stress/random/Write.java, lines 87-88
> > <https://reviews.apache.org/r/23093/diff/1/?file=618989#file618989line87>
> >
> >     Might just be RB, but the indent here looks off.
> 
> Bill Havanki wrote:
>     The argument "opts.max_cells_per_mutation" should be at the same indent level as
the first "new RandomWithinRange" above it and the "new RandomByteArrays" above that; they
are all arguments to the RandomMutations constructor. The close paren after "max_cells_per_mutation"
ends the arg list for that constructor, and the ");" on the next line closes the call to "new
DataWriter".
>     
>     It looks like what I have in my editor in RB ... so given all that, is it OK?
> 
> Mike Drob wrote:
>     Ah, yes, I was misreading, and thought that this was an argument to the previous
constructor.

Yes. Much tabs.


- Bill


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23093/#review47012
-----------------------------------------------------------


On July 1, 2014, 12:23 p.m., Bill Havanki wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23093/
> -----------------------------------------------------------
> 
> (Updated July 1, 2014, 12:23 p.m.)
> 
> 
> Review request for accumulo and Bill Slacum.
> 
> 
> Bugs: ACCUMULO-2947
>     https://issues.apache.org/jira/browse/ACCUMULO-2947
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> A new switch to the memory stress test Write utility, --max-cells-per-mutation, controls
the maximum number of cells to be written in any mutation. If the maximum is hit before the
configured row width, the current mutation is used and the next mutation picks up where it
left off, in the same row.
> 
> The core logic is in the RandomMutations class. It uses a counter for how many cells
are remaining in the current row, with 0 indicating that a new row should be started. Otherwise,
the last row is used. The counter is used as the loop counter for writing cells. When it hits
zero or the maximum, writes stop.
> 
> 
> Diffs
> -----
> 
>   test/src/main/java/org/apache/accumulo/test/stress/random/RandomMutations.java c4504b2

>   test/src/main/java/org/apache/accumulo/test/stress/random/Write.java 9c29871 
>   test/src/main/java/org/apache/accumulo/test/stress/random/WriteOptions.java c213528

>   test/system/stress/stress-env.sh.example 1360c67 
>   test/system/stress/writer.sh 7d9b283 
> 
> Diff: https://reviews.apache.org/r/23093/diff/
> 
> 
> Testing
> -------
> 
> Ran memory stress test on single-node 1.5.2 cluster. With max-cells-per-mutation = 4
and row-width ranging from 1 to 7, saw rows still being written with 5 or more cells.
> 
> 
> Thanks,
> 
> Bill Havanki
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message