Return-Path: X-Original-To: apmail-accumulo-dev-archive@www.apache.org Delivered-To: apmail-accumulo-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id EDD6B11324 for ; Sun, 15 Jun 2014 20:03:27 +0000 (UTC) Received: (qmail 71895 invoked by uid 500); 15 Jun 2014 20:03:27 -0000 Delivered-To: apmail-accumulo-dev-archive@accumulo.apache.org Received: (qmail 71857 invoked by uid 500); 15 Jun 2014 20:03:27 -0000 Mailing-List: contact dev-help@accumulo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@accumulo.apache.org Delivered-To: mailing list dev@accumulo.apache.org Received: (qmail 71845 invoked by uid 99); 15 Jun 2014 20:03:27 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 15 Jun 2014 20:03:27 +0000 X-ASF-Spam-Status: No, hits=1.5 required=5.0 tests=HTML_MESSAGE,RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of vicky.kak@gmail.com designates 209.85.160.176 as permitted sender) Received: from [209.85.160.176] (HELO mail-yk0-f176.google.com) (209.85.160.176) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 15 Jun 2014 20:03:25 +0000 Received: by mail-yk0-f176.google.com with SMTP id 131so3517580ykp.21 for ; Sun, 15 Jun 2014 13:03:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; bh=DZYdg/ieqq45QwcuQZ1MFdjLX0Jg8W+YGfz1nFCEiJ4=; b=Odd66qU2ubOIp2TimX67diIeoe8BvZJrrLXIyT8G4Ud/sC5r5fCsPqr2vwmwKMDqWP 868I9xxA1nFKK0ZXUTK/WuVA7/slJrmEOGfLAMEp2UnTWB10QSwUNmZ02JlJ0i/WOs7G 16PVndzf+guI/it0d5vdrnzo92n5tbZfGlKCEoaPGG1fvH/M4bRcWMI/ZC6lUQVYQlIW seUaGksFH7c7o/+LG6fYE7DO5eDLZXfnrLKlLNb1hq+Lg8HRKQ9CWcA4upTKJ+VfYv01 j3B6vFJ137Um7lZKErm7i8PfEbFYhyawqkgLLrw75HpbWhAmqlwrDFPowsEi0QBy4yWw BW4Q== MIME-Version: 1.0 X-Received: by 10.236.89.69 with SMTP id b45mr27967338yhf.16.1402862580863; Sun, 15 Jun 2014 13:03:00 -0700 (PDT) Received: by 10.170.135.147 with HTTP; Sun, 15 Jun 2014 13:03:00 -0700 (PDT) In-Reply-To: References: Date: Mon, 16 Jun 2014 01:33:00 +0530 Message-ID: Subject: Re: Accumulo shell remote debugger settings. From: Vicky Kak To: dev@accumulo.apache.org Content-Type: multipart/alternative; boundary=20cf300e5241cd181704fbe565de X-Virus-Checked: Checked by ClamAV on apache.org --20cf300e5241cd181704fbe565de Content-Type: text/plain; charset=UTF-8 Ah Sorry I meant not to enable it by default i.e I am **not** suggesting that we should make the remote debugging enabled by default but have the other property for the shell command which does not collide with the generic properties I would propose to have ACCUMULO_SHELL_OPTS without the debugger ports by default. On Mon, Jun 16, 2014 at 1:21 AM, Josh Elser wrote: > I'm not completely sold that we should be enabling them by default. I think > it would create more confusion and problems for the average user. > Additionally, with the proposed ACCUMULO_SHELL_OPTS, you have the ability > to easily enable them for yourself. > > With the configuration generation tool included with 1.6.0, I could see > options that allow you to enable the ports too. > On Jun 15, 2014 9:32 AM, "Vicky Kak" wrote: > > > Yes that is correct, the ports are going to collide. > > I am suggesting that we should make the remote debugging enabled by > default > > but have the other property for the shell command which does not collide > > with the generic properties > > > > > > On Sun, Jun 15, 2014 at 7:58 PM, Josh Elser > wrote: > > > > > I think Vicky is just noting that each process would have to be defined > > > individually and not use ACCUMULO_GENERAL_OPTS as the debugger ports > > would > > > collide. > > > > > > I think making an ACCUMULO_SHELL_OPTS is fine. > > > On Jun 15, 2014 8:38 AM, "William Slacum" < > > wilhelm.von.cloud@accumulo.net> > > > wrote: > > > > > > > Putting the flag in the process/module OPTs is fine. It's what I > > normally > > > > do when I want to debug. Are you suggesting we have remote debugging > > > > enabled by default? > > > > > > > > > > > > On Sun, Jun 15, 2014 at 9:11 AM, Vicky Kak > > wrote: > > > > > > > > > While trying to get the remote debugger running with accumulo I > > figured > > > > > that for the accumulo shell command we need to introduce the > > following > > > > > changes > > > > > > > > > > 1) test -z "$ACCUMULO_SHELL_OPTS" && export > > > > ACCUMULO_SHELL_OPTS="-Xmx128m > > > > > -Xms64m > > -Xrunjdwp:server=y,transport=dt_socket,address=4002,suspend=n" > > > > > > > > > > in accumulo-env.sh > > > > > > > > > > 2) > > > > > include the additional case in accumulo.sh > > > > > > > > > > shell) export ACCUMULO_OPTS="${ACCUMULO_GENERAL_OPTS} > > > > > ${ACCUMULO_SHELL_OPTS}" ;; > > > > > > > > > > We can't define the debugger port in the $ACCUMULO_OTHER_OPTS in > the > > > > > accumulo-env.sh as that would be bind when start-all.sh is called. > > > > > > > > > > Before I raise a JIRA for this a provide a patch I would like to > hear > > > the > > > > > option from others how they enable the remote debugging for the > shell > > > > > command. > > > > > > > > > > Thanks, > > > > > Vicky > > > > > > > > > > > > > > > --20cf300e5241cd181704fbe565de--