Mailing-List: contact dev-help@accumulo.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@accumulo.apache.org
Received-SPF: pass (nike.apache.org: domain of josh.elser@gmail.com designates
 209.85.219.45 as permitted sender)
MIME-Version: 1.0
In-Reply-To: 
 <CAPaCpY888S9GYrD4WQnXEoKsJgJByT5cOrHPnyB94kJaexGULQ@mail.gmail.com>
References: 
 <CAPaCpY_cMdS9GekM6YVBFvSceak78ES2DytOX4GHCtwOGogUEw@mail.gmail.com>
	<CAMz+Dut4=_5p4u-2q-cBv41oEqTekfkPKb9JQ0D6+GZiGO3h1A@mail.gmail.com>
	<CAOyNEs7hbNhvBfVtoDyN4rpRWX3hwjjV5hDBLD=AWkSjOrz8Vg@mail.gmail.com>
	<CAPaCpY888S9GYrD4WQnXEoKsJgJByT5cOrHPnyB94kJaexGULQ@mail.gmail.com>
Date: Sun, 15 Jun 2014 15:51:15 -0400
Message-ID: 
 <CAOyNEs7ywSjSRCByLRybfXvjrBcuj4Tq3xf1R_GrVOEJHNUrGg@mail.gmail.com>
Subject: Re: Accumulo shell remote debugger settings.
From: Josh Elser <josh.elser@gmail.com>
To: dev@accumulo.apache.org
Content-Type: multipart/alternative; boundary=001a11c2e35ec3e5b104fbe53b2f

--001a11c2e35ec3e5b104fbe53b2f
Content-Type: text/plain; charset=UTF-8

I'm not completely sold that we should be enabling them by default. I think
it would create more confusion and problems for the average user.
Additionally, with the proposed ACCUMULO_SHELL_OPTS, you have the ability
to easily enable them for yourself.

With the configuration generation tool included with 1.6.0, I could see
options that allow you to enable the ports too.
On Jun 15, 2014 9:32 AM, "Vicky Kak" <vicky.kak@gmail.com> wrote:

> Yes that is correct, the ports are going to collide.
> I am suggesting that we should make the remote debugging enabled by default
> but have the other property for the shell command which does not collide
> with the generic properties
>
>
> On Sun, Jun 15, 2014 at 7:58 PM, Josh Elser <josh.elser@gmail.com> wrote:
>
> > I think Vicky is just noting that each process would have to be defined
> > individually and not use ACCUMULO_GENERAL_OPTS  as the debugger ports
> would
> > collide.
> >
> > I think making an ACCUMULO_SHELL_OPTS is fine.
> > On Jun 15, 2014 8:38 AM, "William Slacum" <
> wilhelm.von.cloud@accumulo.net>
> > wrote:
> >
> > > Putting the flag in the process/module OPTs is fine. It's what I
> normally
> > > do when I want to debug. Are you suggesting we have remote debugging
> > > enabled by default?
> > >
> > >
> > > On Sun, Jun 15, 2014 at 9:11 AM, Vicky Kak <vicky.kak@gmail.com>
> wrote:
> > >
> > > > While trying to get the remote debugger running with accumulo I
> figured
> > > > that for the accumulo shell command we need to introduce the
> following
> > > > changes
> > > >
> > > > 1) test -z "$ACCUMULO_SHELL_OPTS"   && export
> > > ACCUMULO_SHELL_OPTS="-Xmx128m
> > > > -Xms64m
> -Xrunjdwp:server=y,transport=dt_socket,address=4002,suspend=n"
> > > >
> > > > in accumulo-env.sh
> > > >
> > > > 2)
> > > > include the additional case in accumulo.sh
> > > >
> > > > shell)  export ACCUMULO_OPTS="${ACCUMULO_GENERAL_OPTS}
> > > > ${ACCUMULO_SHELL_OPTS}" ;;
> > > >
> > > > We can't define the debugger port in the $ACCUMULO_OTHER_OPTS in the
> > > > accumulo-env.sh as that would be bind when start-all.sh is called.
> > > >
> > > > Before I raise a JIRA for this a provide a patch I would like to hear
> > the
> > > > option from others how they enable the remote debugging for the shell
> > > > command.
> > > >
> > > > Thanks,
> > > > Vicky
> > > >
> > >
> >
>

--001a11c2e35ec3e5b104fbe53b2f--