Return-Path: 
 <dev-return-10201-apmail-accumulo-dev-archive=accumulo.apache.org@accumulo.apache.org>
X-Original-To: apmail-accumulo-dev-archive@www.apache.org
Delivered-To: apmail-accumulo-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 08F5411DD3
	for <apmail-accumulo-dev-archive@www.apache.org>;
 Wed, 18 Jun 2014 23:59:37 +0000 (UTC)
Received: (qmail 36239 invoked by uid 500); 18 Jun 2014 23:59:36 -0000
Delivered-To: apmail-accumulo-dev-archive@accumulo.apache.org
Received: (qmail 36199 invoked by uid 500); 18 Jun 2014 23:59:36 -0000
Mailing-List: contact dev-help@accumulo.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@accumulo.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@accumulo.apache.org>
List-Post: <mailto:dev@accumulo.apache.org>
List-Id: <dev.accumulo.apache.org>
Reply-To: dev@accumulo.apache.org
Delivered-To: mailing list dev@accumulo.apache.org
Received: (qmail 36186 invoked by uid 99); 18 Jun 2014 23:59:36 -0000
Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 18 Jun 2014 23:59:36 +0000
Received: from reviews.apache.org (localhost [127.0.0.1])
	by reviews.apache.org (Postfix) with ESMTP id 9C0031DB0EB;
	Wed, 18 Jun 2014 23:59:26 +0000 (UTC)
Content-Type: multipart/alternative;
 boundary="===============7753646656997111830=="
MIME-Version: 1.0
Subject: Re: Review Request 22537: HeapIterator optimization
From: "Jonathan Park" <parkjsung@gmail.com>
To: "Jonathan Park" <parkjsung@gmail.com>, "Mike Drob" <mdrob@mdrob.com>,
 "accumulo" <dev@accumulo.apache.org>
Date: Wed, 18 Jun 2014 23:59:26 -0000
Message-ID: <20140618235926.6311.29817@reviews.apache.org>
X-ReviewBoard-URL: https://reviews.apache.org
Auto-Submitted: auto-generated
Sender: "Jonathan Park" <noreply@reviews.apache.org>
X-ReviewGroup: accumulo
X-ReviewRequest-URL: https://reviews.apache.org/r/22537/
X-Sender: "Jonathan Park" <noreply@reviews.apache.org>
References: <20140612230341.22323.6998@reviews.apache.org>
In-Reply-To: <20140612230341.22323.6998@reviews.apache.org>
Reply-To: "Jonathan Park" <parkjsung@gmail.com>
X-ReviewRequest-Repository: accumulo

--===============7753646656997111830==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit



> On June 12, 2014, 11:03 p.m., Mike Drob wrote:
> > Can you add a unit test to ensure correctness? Something as simple as sorting from two iterators that have a couple values each. Also checking empty values.

Thank you for the review and sorry for the delay.

As for unit tests, I second what kturner mentioned but I'll make a sanity pass through the MultiIteratorTest to see if there are some interesting cases that could be added.


> On June 12, 2014, 11:03 p.m., Mike Drob wrote:
> > core/src/main/java/org/apache/accumulo/core/iterators/system/HeapIterator.java, line 28
> > <https://reviews.apache.org/r/22537/diff/1/?file=608354#file608354line28>
> >
> >     Can we switch this to be a java.util.PriorityQueue<E>? It will save us on unsafe casts when we pop elements.

This is a good suggestion. The unsafe casts also bother me. 

I'll work towards getting that in.


- Jonathan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22537/#review45550
-----------------------------------------------------------


On June 12, 2014, 9:54 p.m., Jonathan Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22537/
> -----------------------------------------------------------
> 
> (Updated June 12, 2014, 9:54 p.m.)
> 
> 
> Review request for accumulo.
> 
> 
> Bugs: ACCUMULO-2827
>     https://issues.apache.org/jira/browse/ACCUMULO-2827
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> HeapIterator optimization to avoid always re-inserting back into the heap.
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/accumulo/core/iterators/system/HeapIterator.java e54f37c 
>   core/src/test/java/org/apache/accumulo/core/iterators/system/BenchmarkMultiIterator.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/22537/diff/
> 
> 
> Testing
> -------
> 
> mvn clean install
> 
> accumulo continuous ingest: saw ~5% improvement on uniformly distributed data. (see ticket for more details)
> 
> 
> Thanks,
> 
> Jonathan Park
> 
>


--===============7753646656997111830==--