Mailing-List: contact dev-help@accumulo.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@accumulo.apache.org
Content-Type: multipart/alternative;
 boundary="===============6074816036930691124=="
MIME-Version: 1.0
Subject: Re: Review Request 22537: HeapIterator optimization
From: keith@deenlo.com
To: "Jonathan Park" <parkjsung@gmail.com>,
 "accumulo" <dev@accumulo.apache.org>,
 keith@deenlo.com
Date: Wed, 18 Jun 2014 23:43:50 -0000
Message-ID: <20140618234350.13794.47089@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: noreply@reviews.apache.org
References: <20140618231423.13794.18805@reviews.apache.org>
In-Reply-To: <20140618231423.13794.18805@reviews.apache.org>
Reply-To: keith@deenlo.com

--===============6074816036930691124==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit


> On June 18, 2014, 11:14 p.m., kturner wrote:
> > I took a look at the code.  The changes look good.  I am going to try running an end to end experiment like the one you ran w/ CI.  However I am going to generate random rows with multiple columns.

HeapIterator has no unit test itself, but its well covered by the MultiIteratorTest and RFileTest.  I ran those two test w/ the patch and looked at code coverage, its almost 100%.  The only things not covered were the cases where IllegalStateException was thrown.


- kturner


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22537/#review46142
-----------------------------------------------------------


On June 12, 2014, 9:54 p.m., Jonathan Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22537/
> -----------------------------------------------------------
> 
> (Updated June 12, 2014, 9:54 p.m.)
> 
> 
> Review request for accumulo.
> 
> 
> Bugs: ACCUMULO-2827
>     https://issues.apache.org/jira/browse/ACCUMULO-2827
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> HeapIterator optimization to avoid always re-inserting back into the heap.
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/accumulo/core/iterators/system/HeapIterator.java e54f37c 
>   core/src/test/java/org/apache/accumulo/core/iterators/system/BenchmarkMultiIterator.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/22537/diff/
> 
> 
> Testing
> -------
> 
> mvn clean install
> 
> accumulo continuous ingest: saw ~5% improvement on uniformly distributed data. (see ticket for more details)
> 
> 
> Thanks,
> 
> Jonathan Park
> 
>


--===============6074816036930691124==--