Mailing-List: contact dev-help@accumulo.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@accumulo.apache.org
Content-Type: multipart/alternative;
 boundary="===============3044736151974709844=="
MIME-Version: 1.0
Subject: Re: Review Request 22399: ACCUMULO-2876 - use site config for default
 VolumeManagerImpl
From: "Bill Havanki" <bhavanki@clouderagovt.com>
To: "Eric Newton" <eric.newton@gmail.com>, "Josh Elser" <josh.elser@gmail.com>
Cc: "Bill Havanki" <bhavanki@clouderagovt.com>,
 "accumulo" <dev@accumulo.apache.org>
Date: Mon, 09 Jun 2014 21:01:14 -0000
Message-ID: <20140609210114.22324.99318@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Bill Havanki" <noreply@reviews.apache.org>
References: <20140609205921.22324.64361@reviews.apache.org>
In-Reply-To: <20140609205921.22324.64361@reviews.apache.org>
Reply-To: "Bill Havanki" <bhavanki@clouderagovt.com>

--===============3044736151974709844==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit


> On June 9, 2014, 4:59 p.m., Josh Elser wrote:
> > Please make a follow-on for making Property.GENERAL_VOLUME_CHOOSER a fixed property since you didn't make that change here. Thanks.

Will do.

/me presses Publish. :)


- Bill


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22399/#review45139
-----------------------------------------------------------


On June 9, 2014, 4:47 p.m., Bill Havanki wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22399/
> -----------------------------------------------------------
> 
> (Updated June 9, 2014, 4:47 p.m.)
> 
> 
> Review request for accumulo, Eric Newton and Josh Elser.
> 
> 
> Bugs: ACCUMULO-2876
>     https://issues.apache.org/jira/browse/ACCUMULO-2876
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> This changes VolumeManagerImpl.get() to use the site configuration instead of the ZooKeeper-based system configuration. This seems to align better with what is intended, and it also eliminates the risk of an infinite loop, where the system configuration requires an HdfsZooInstance instance ID, which requires a volume manager.
> 
> 
> Diffs
> -----
> 
>   server/base/src/main/java/org/apache/accumulo/server/fs/VolumeManagerImpl.java 8fe6579 
> 
> Diff: https://reviews.apache.org/r/22399/diff/
> 
> 
> Testing
> -------
> 
> All unit tests pass. The fix also rectified the loop in SystemCredentialsTest after refactoring for ACCUMULO-2615.
> 
> 
> Thanks,
> 
> Bill Havanki
> 
>


--===============3044736151974709844==--