Return-Path: X-Original-To: apmail-accumulo-dev-archive@www.apache.org Delivered-To: apmail-accumulo-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C353D11FD6 for ; Fri, 6 Jun 2014 16:43:22 +0000 (UTC) Received: (qmail 7088 invoked by uid 500); 6 Jun 2014 16:43:22 -0000 Delivered-To: apmail-accumulo-dev-archive@accumulo.apache.org Received: (qmail 7030 invoked by uid 500); 6 Jun 2014 16:43:22 -0000 Mailing-List: contact dev-help@accumulo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@accumulo.apache.org Delivered-To: mailing list dev@accumulo.apache.org Received: (qmail 7011 invoked by uid 99); 6 Jun 2014 16:43:21 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 06 Jun 2014 16:43:21 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id D33981D9946; Fri, 6 Jun 2014 16:43:12 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2511335563645225478==" MIME-Version: 1.0 Subject: Re: Review Request 22308: ACCUMULO-2865 - ZooCacheTest From: "Josh Elser" To: "Bill Havanki" , "accumulo" , "Josh Elser" Date: Fri, 06 Jun 2014 16:43:12 -0000 Message-ID: <20140606164312.10017.16320@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Josh Elser" X-ReviewGroup: accumulo X-ReviewRequest-URL: https://reviews.apache.org/r/22308/ X-Sender: "Josh Elser" References: <20140606163614.10016.21774@reviews.apache.org> In-Reply-To: <20140606163614.10016.21774@reviews.apache.org> Reply-To: "Josh Elser" X-ReviewRequest-Repository: accumulo --===============2511335563645225478== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22308/#review44910 ----------------------------------------------------------- Ship it! Formatting on the test class, otherwise LGTM. - Josh Elser On June 6, 2014, 4:36 p.m., Bill Havanki wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22308/ > ----------------------------------------------------------- > > (Updated June 6, 2014, 4:36 p.m.) > > > Review request for accumulo. > > > Bugs: ACCUMULO-2865 > https://issues.apache.org/jira/browse/ACCUMULO-2865 > > > Repository: accumulo > > > Description > ------- > > This adds a unit test for ZooCache. ZooCache itself was only changed slightly, with the addition of methods to check if information was cached and improvements to its comments. > > > Diffs > ----- > > fate/src/main/java/org/apache/accumulo/fate/zookeeper/ZooCache.java 99ffd04 > fate/src/test/java/org/apache/accumulo/fate/zookeeper/ZooCacheTest.java PRE-CREATION > > Diff: https://reviews.apache.org/r/22308/diff/ > > > Testing > ------- > > Unit tests pass, including ZooCacheTest. > > > Thanks, > > Bill Havanki > > --===============2511335563645225478==--