Return-Path: X-Original-To: apmail-accumulo-dev-archive@www.apache.org Delivered-To: apmail-accumulo-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 400921123C for ; Tue, 3 Jun 2014 19:22:13 +0000 (UTC) Received: (qmail 69669 invoked by uid 500); 3 Jun 2014 19:22:13 -0000 Delivered-To: apmail-accumulo-dev-archive@accumulo.apache.org Received: (qmail 69617 invoked by uid 500); 3 Jun 2014 19:22:13 -0000 Mailing-List: contact dev-help@accumulo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@accumulo.apache.org Delivered-To: mailing list dev@accumulo.apache.org Received: (qmail 69605 invoked by uid 99); 3 Jun 2014 19:22:13 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 03 Jun 2014 19:22:13 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 479F81D9AB4; Tue, 3 Jun 2014 19:22:04 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4043814616794693806==" MIME-Version: 1.0 Subject: Re: Review Request 22003: Replication: Client-facing changes From: "Bill Havanki" To: "Bill Havanki" , "accumulo" , "Josh Elser" Date: Tue, 03 Jun 2014 19:22:04 -0000 Message-ID: <20140603192204.12450.85694@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Bill Havanki" X-ReviewGroup: accumulo X-ReviewRequest-URL: https://reviews.apache.org/r/22003/ X-Sender: "Bill Havanki" References: <20140529025306.12586.94951@reviews.apache.org> In-Reply-To: <20140529025306.12586.94951@reviews.apache.org> Reply-To: "Bill Havanki" X-ReviewRequest-Repository: accumulo --===============4043814616794693806== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22003/#review44655 ----------------------------------------------------------- core/src/main/java/org/apache/accumulo/core/client/replication/ReplicationTable.java Private constructor or convert to regular, non-utility class (preferred by yours truly). Also, the class doesn't really represent the replication table, so renaming it might be good. I do *not* suggest StuffYouCanDoWithReplicationTable. core/src/main/java/org/apache/accumulo/core/conf/Property.java sp: replication core/src/main/java/org/apache/accumulo/core/data/Mutation.java This might NPE if replicationSources is null. It might be good to simply assure it can never be. core/src/main/java/org/apache/accumulo/core/data/Mutation.java replicationSources might be null? - Bill Havanki On May 28, 2014, 10:52 p.m., Josh Elser wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22003/ > ----------------------------------------------------------- > > (Updated May 28, 2014, 10:52 p.m.) > > > Review request for accumulo. > > > Bugs: ACCUMULO-378 > https://issues.apache.org/jira/browse/ACCUMULO-378 > > > Repository: accumulo > > > Description > ------- > > "Public-facing" changes. Thrift IDLs, protobufs, client API additions, monitor additions. > > > Diffs > ----- > > core/pom.xml 2c3f648 > core/src/main/java/org/apache/accumulo/core/Constants.java 7d602bb > core/src/main/java/org/apache/accumulo/core/client/Connector.java 4a2acff > core/src/main/java/org/apache/accumulo/core/client/admin/ReplicationOperations.java PRE-CREATION > core/src/main/java/org/apache/accumulo/core/client/impl/ConnectorImpl.java 0df35f6 > core/src/main/java/org/apache/accumulo/core/client/impl/MasterClient.java 1fa8f12 > core/src/main/java/org/apache/accumulo/core/client/impl/ReplicationClient.java PRE-CREATION > core/src/main/java/org/apache/accumulo/core/client/impl/ReplicationOperationsImpl.java PRE-CREATION > core/src/main/java/org/apache/accumulo/core/client/mock/MockAccumulo.java 2c26ecc > core/src/main/java/org/apache/accumulo/core/client/mock/MockConnector.java 996198c > core/src/main/java/org/apache/accumulo/core/client/mock/MockTable.java cb50761 > core/src/main/java/org/apache/accumulo/core/client/mock/MockTableOperations.java a44a027 > core/src/main/java/org/apache/accumulo/core/client/replication/PeerExistsException.java PRE-CREATION > core/src/main/java/org/apache/accumulo/core/client/replication/PeerNotFoundException.java PRE-CREATION > core/src/main/java/org/apache/accumulo/core/client/replication/ReplicaSystem.java PRE-CREATION > core/src/main/java/org/apache/accumulo/core/client/replication/ReplicaSystemFactory.java PRE-CREATION > core/src/main/java/org/apache/accumulo/core/client/replication/ReplicationTable.java PRE-CREATION > core/src/main/java/org/apache/accumulo/core/conf/Property.java 1200fd1 > core/src/main/java/org/apache/accumulo/core/data/ConditionalMutation.java e43968c > core/src/main/java/org/apache/accumulo/core/data/Mutation.java 42fa143 > core/src/main/java/org/apache/accumulo/core/data/thrift/MultiScanResult.java f0b8a87 > core/src/main/java/org/apache/accumulo/core/data/thrift/ScanResult.java 6472587 > core/src/main/java/org/apache/accumulo/core/data/thrift/TConditionalMutation.java 3f9b3f7 > core/src/main/java/org/apache/accumulo/core/data/thrift/TMutation.java f698892 > core/src/main/java/org/apache/accumulo/core/data/thrift/UpdateErrors.java 59ce5cb > core/src/main/java/org/apache/accumulo/core/iterators/Combiner.java ceb4411 > core/src/main/java/org/apache/accumulo/core/metadata/schema/MetadataSchema.java 06eae23 > core/src/main/java/org/apache/accumulo/core/protobuf/ProtobufUtil.java PRE-CREATION > core/src/main/java/org/apache/accumulo/core/replication/AccumuloReplicationReplayer.java PRE-CREATION > core/src/main/java/org/apache/accumulo/core/replication/PrintReplicationRecords.java PRE-CREATION > core/src/main/java/org/apache/accumulo/core/replication/ReplicaSystemHelper.java PRE-CREATION > core/src/main/java/org/apache/accumulo/core/replication/ReplicationConfigurationUtil.java PRE-CREATION > core/src/main/java/org/apache/accumulo/core/replication/ReplicationSchema.java PRE-CREATION > core/src/main/java/org/apache/accumulo/core/replication/ReplicationTarget.java PRE-CREATION > core/src/main/java/org/apache/accumulo/core/replication/StatusFormatter.java PRE-CREATION > core/src/main/java/org/apache/accumulo/core/replication/StatusUtil.java PRE-CREATION > core/src/main/java/org/apache/accumulo/core/replication/proto/Replication.java PRE-CREATION > core/src/main/java/org/apache/accumulo/core/replication/thrift/KeyValues.java PRE-CREATION > core/src/main/java/org/apache/accumulo/core/replication/thrift/RemoteReplicationErrorCode.java PRE-CREATION > core/src/main/java/org/apache/accumulo/core/replication/thrift/RemoteReplicationException.java PRE-CREATION > core/src/main/java/org/apache/accumulo/core/replication/thrift/Replication.java PRE-CREATION > core/src/main/java/org/apache/accumulo/core/replication/thrift/ReplicationCoordinator.java PRE-CREATION > core/src/main/java/org/apache/accumulo/core/replication/thrift/ReplicationCoordinatorErrorCode.java PRE-CREATION > core/src/main/java/org/apache/accumulo/core/replication/thrift/ReplicationCoordinatorException.java PRE-CREATION > core/src/main/java/org/apache/accumulo/core/replication/thrift/ReplicationServicer.java PRE-CREATION > core/src/main/java/org/apache/accumulo/core/replication/thrift/WalEdits.java PRE-CREATION > core/src/main/java/org/apache/accumulo/core/schema/Section.java PRE-CREATION > core/src/main/java/org/apache/accumulo/core/tabletserver/thrift/ReplicationFailedException.java PRE-CREATION > core/src/main/protobuf/replication.proto PRE-CREATION > core/src/main/scripts/generate-protobuf.sh PRE-CREATION > core/src/main/scripts/generate-thrift.sh 5a5d69f > core/src/main/thrift/data.thrift ae6f439 > core/src/main/thrift/replication.thrift PRE-CREATION > core/src/test/java/org/apache/accumulo/core/replication/ReplicationConfigurationUtilTest.java PRE-CREATION > core/src/test/java/org/apache/accumulo/core/replication/ReplicationOperationsImplTest.java PRE-CREATION > core/src/test/java/org/apache/accumulo/core/replication/ReplicationSchemaTest.java PRE-CREATION > core/src/test/java/org/apache/accumulo/core/replication/ReplicationTargetTest.java PRE-CREATION > core/src/test/java/org/apache/accumulo/core/replication/StatusUtilTest.java PRE-CREATION > core/src/test/java/org/apache/accumulo/core/replication/proto/StatusTest.java PRE-CREATION > docs/src/main/asciidoc/accumulo_user_manual.asciidoc fec40ca > docs/src/main/asciidoc/chapters/replication.txt PRE-CREATION > docs/src/main/resources/design/ACCUMULO-378-design.mdtext PRE-CREATION > docs/src/main/resources/state/replicationstatus.gv PRE-CREATION > docs/src/main/resources/state/replicationstatus.png PRE-CREATION > minicluster/src/main/java/org/apache/accumulo/minicluster/impl/MiniAccumuloConfigImpl.java 3258991 > server/monitor/pom.xml 411812c > server/monitor/src/main/java/org/apache/accumulo/monitor/Monitor.java e6617d0 > server/monitor/src/main/java/org/apache/accumulo/monitor/servlets/BasicServlet.java 86a84b9 > server/monitor/src/main/java/org/apache/accumulo/monitor/servlets/ReplicationServlet.java PRE-CREATION > > Diff: https://reviews.apache.org/r/22003/diff/ > > > Testing > ------- > > > Thanks, > > Josh Elser > > --===============4043814616794693806==--