accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Park" <>
Subject Re: Review Request 22658: ACCUMULO-2889: Batch metadata updates for new WALs
Date Fri, 27 Jun 2014 17:41:03 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated June 27, 2014, 5:41 p.m.)

Review request for accumulo.


Incorporating feedback from reviews.

- Moved Writer into a server-only class
- Re-using BatchWriterImpl instead of rolling our own batching code

Bugs: ACCUMULO-2889

Repository: accumulo


Added additional methods to the Writer class to handle batching. 

Potential risks are that we're now holding onto the locks for a bit longer than we used to.
All tablets present in a batch will have their logLock's locked until the batch is complete.

Diffs (updated)

  core/src/main/java/org/apache/accumulo/core/client/impl/ d6762e7 
  server/base/src/main/java/org/apache/accumulo/server/util/ PRE-CREATION

  server/base/src/main/java/org/apache/accumulo/server/util/ 374017d

  server/tserver/src/main/java/org/apache/accumulo/tserver/ 36b2289 
  server/tserver/src/main/java/org/apache/accumulo/tserver/ 57415bd 
  server/tserver/src/main/java/org/apache/accumulo/tserver/log/ d25ee75

  test/src/test/java/org/apache/accumulo/server/util/ PRE-CREATION

  test/src/test/java/org/apache/accumulo/test/ PRE-CREATION 



Added a new IT.

We insert a few entries to tablets and ensure that the relevant entries appear in the WAL
and Metadata Table.
One test case that isn't included yet is verifying that root + metadata table entries are
entered correctly.


Jonathan Park

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message