accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From haydenmarchant <...@git.apache.org>
Subject [GitHub] accumulo pull request: Fixes harded coded Sun JVM in config and en...
Date Wed, 25 Jun 2014 08:06:04 GMT
Github user haydenmarchant commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/9#discussion_r14173113
  
    --- Diff: bin/bootstrap_config.sh ---
    @@ -119,6 +123,86 @@ while [[ "${OVERWRITE}" = "0" ]]; do
     done
     echo "Coppying configuration files to: ${CONF_DIR}"
     
    +if [[ -z "${SIZE}" ]]; then
    --- End diff --
    
    I thought that it would be best to keep all the user input in one chunk.
    
    Do you think that I should revert the relocation of the other selects and just put the
JVM down below instead? If so, that's not a problem.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message