accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From busbey <...@git.apache.org>
Subject [GitHub] accumulo pull request: Fixes harded coded Sun JVM in config and en...
Date Tue, 24 Jun 2014 16:26:52 GMT
Github user busbey commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/9#discussion_r14138959
  
    --- Diff: bin/bootstrap_config.sh ---
    @@ -119,6 +123,86 @@ while [[ "${OVERWRITE}" = "0" ]]; do
     done
     echo "Coppying configuration files to: ${CONF_DIR}"
     
    +if [[ -z "${SIZE}" ]]; then
    --- End diff --
    
    Why move the memory / mmap type/ hadoop code up here? Could you just prompt for the JVM
instead?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message