accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From madrob <...@git.apache.org>
Subject [GitHub] accumulo pull request: Fixes harded coded Sun JVM in config and en...
Date Tue, 24 Jun 2014 15:25:42 GMT
Github user madrob commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/9#discussion_r14135462
  
    --- Diff: bin/bootstrap_config.sh ---
    @@ -119,6 +123,86 @@ while [[ "${OVERWRITE}" = "0" ]]; do
     done
     echo "Coppying configuration files to: ${CONF_DIR}"
     
    +if [[ -z "${SIZE}" ]]; then
    +  echo "Choose the heap configuration:"
    +  select DIRNAME in 1GB 2GB 3GB 512MB; do
    +    echo "Using '${DIRNAME}' configuration"
    +    SIZE=${DIRNAME}
    +    break
    +  done
    +elif [[ "${SIZE}" != "1GB" && "${SIZE}" != "2GB"  && "${SIZE}" != "3GB"
&& "${SIZE}" != "512MB" ]]; then
    +  echo "Invalid memory size"
    +  echo "Supported sizes: '1GB' '2GB' '3GB' '512MB'"
    +  exit 1
    +fi
    +
    +if [[ -z "${TYPE}" ]]; then
    +  echo
    +  echo "Choose the Accumulo memory-map type:"
    +  select TYPENAME in Java Native; do
    +    if [[ "${TYPENAME}" == "Native" ]]; then
    +      TYPE="native"
    +      echo "Don't forget to build the native libraries using the bin/build_native_library.sh
script"
    +    elif [[ "${TYPENAME}" == "Java" ]]; then
    +      TYPE="jvm"
    +    fi
    +    echo "Using '${TYPE}' configuration"
    +    echo
    +    break
    +  done
    +fi
    +
    +if [[ -z "${HADOOP_VERSION}" ]]; then
    +  echo
    +  echo "Choose the Apache Hadoop version:"
    +  select HADOOP in 'HADOOP 1' 'HADOOP 2' ; do
    +    if [ "${HADOOP}" == "HADOOP 2" ]; then
    +      HADOOP_VERSION="2"
    +    elif [ "${HADOOP}" == "HADOOP 1" ]; then
    +      HADOOP_VERSION="1"
    +    fi
    +    echo "Using Apache Hadoop version '${HADOOP_VERSION}' configuration"
    +    echo
    +    break
    +  done
    +elif [[ "${HADOOP_VERSION}" != "1" && "${HADOOP_VERSION}" != "2" ]]; then
    +  echo "Invalid Apache Hadoop version"
    +  echo "Supported Apache Hadoop versions: '1' '2'"
    +  exit 1
    +fi
    +
    +for var in SIZE TYPE HADOOP_VERSION; do
    +  if [[ -z ${!var} ]]; then
    +    echo "Invalid $var configuration"
    +    exit 1
    +  fi
    +done
    +
    +if [[ -z "${JVM_VENDOR}" ]]; then
    +  echo 
    +  echo "Choose Java vendor:"
    +  select SEL_JVM_VENDOR in Sun OpenJDK IBM Other; do
    +    echo "Using configuration for ${SEL_JVM_VENDOR} JVM"
    +    JVM_VENDOR=${SEL_JVM_VENDOR}
    +    echo
    +    break
    +  done
    +fi
    +
    +if [[ "${JVM_VENDOR}" == "IBM" ]] ; then
    +  GC_NEWSIZE_PREFIX="-Xmns"
    +  GC_MAXNEWSIZE_PREFIX="-Xmnx"
    +  GC_POLICY_ARGS="-Xgcpolicy:gencon"
    +  JAXP_DOCUMENT_BUILDER_FACTORY_ARGS=""
    +  RNG_PROVIDER_OVERRIDE_ARGS=""
    +else
    +  GC_NEWSIZE_PREFIX="-XX:NewSize="
    +  GC_MAXNEWSIZE_PREFIX="-XX:MaxNewSize="
    +  GC_POLICY_ARGS="-XX:+UseConcMarkSweepGC -XX:CMSInitiatingOccupancyFraction=75" 
    +  JAXP_DOCUMENT_BUILDER_FACTORY_ARGS="-Djavax.xml.parsers.DocumentBuilderFactory=com.sun.org.apache.xerces.internal.jaxp.DocumentBuilderFactoryImpl"
    +  RNG_PROVIDER_OVERRIDE_ARGS="-Dcrypto.secure.rng.provider=IBMJCE"
    --- End diff --
    
    This line looks like it belongs in the other branch of the if.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message