accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Havanki" <bhava...@clouderagovt.com>
Subject Re: Review Request 20525: ACCUMULO-2694 Fix handling of tablet migrations for offline tables.
Date Mon, 23 Jun 2014 23:29:52 GMT


> On June 23, 2014, 5:43 p.m., Bill Havanki wrote:
> > server/src/main/java/org/apache/accumulo/server/master/balancer/TabletBalancer.java,
lines 157-158
> > <https://reviews.apache.org/r/20525/diff/6/?file=615223#file615223line157>
> >
> >     When constraintNotMet() transitions to stuck = true, it won't run the cause
to log it; i.e., the first cause in a series won't get logged.
> 
> Sean Busbey wrote:
>     Correct, it's not supposed to log until the problem has persisted for the threshold
period.

OK. I was concerned that this would lead to under-reporting - for example, a 59-second long
problem would never be logged. But, if the nature of this is that it's fine to not mention
more transient problems (say, a 30-second long problem that flip-flops), I'm good.


- Bill


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20525/#review46455
-----------------------------------------------------------


On June 23, 2014, 5:18 p.m., Sean Busbey wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20525/
> -----------------------------------------------------------
> 
> (Updated June 23, 2014, 5:18 p.m.)
> 
> 
> Review request for accumulo, Eric Newton and Mike Drob.
> 
> 
> Bugs: ACCUMULO-2694
>     https://issues.apache.org/jira/browse/ACCUMULO-2694
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> ACCUMULO-2694 Fix handling of tablet migrations for offline tables.
>     
>     * Adds a funtional test that fails due to not rebalancing
>     * Fix master to clear migrations when it learns that a table has gone offline
>     * Update master to periodically clean up migrations for offline tables
>     * Fix balancers to make sure they log if they can't balance.
> 
> 
> Diffs
> -----
> 
>   server/pom.xml bd61fe6d870449247cde10ae6ed88c98a31657a2 
>   server/src/main/java/org/apache/accumulo/server/master/Master.java a2ad2e65e5766d5760199a2c477679f5616a0710

>   server/src/main/java/org/apache/accumulo/server/master/balancer/ChaoticLoadBalancer.java
e14008a8e4caf72133dd9a08b9aab566bb03d862 
>   server/src/main/java/org/apache/accumulo/server/master/balancer/DefaultLoadBalancer.java
1fcab4681c32b20d04d8ab9e72d6a61eb6bdddf0 
>   server/src/main/java/org/apache/accumulo/server/master/balancer/TabletBalancer.java
69387d365e7207b2faaa91805ca2fe8b432e0d49 
>   test/system/auto/stress/migrations.py d07d7a89ddc930f538f736883d1a3ec43d020d00 
> 
> Diff: https://reviews.apache.org/r/20525/diff/
> 
> 
> Testing
> -------
> 
> Ran functional test without other changes -> failed. After full patch functional test
passes.
> 
> 
> Thanks,
> 
> Sean Busbey
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message