accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Christopher Tubbs" <ctubbsii...@apache.org>
Subject Re: Review Request 20422: ACCUMULO-1834 - Review Board guidelines
Date Tue, 17 Jun 2014 18:49:45 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20422/#review45965
-----------------------------------------------------------



docs/src/main/resources/RB.md
<https://reviews.apache.org/r/20422/#comment81098>

    I've found descriptive ids for links to be more maintainable than integer 1-ups.
    
    Example: replace [instance][1] with [instance][RB_INSTANCE]



docs/src/main/resources/RB.md
<https://reviews.apache.org/r/20422/#comment81099>

    s/can be used in the/can be used to support development in the/



docs/src/main/resources/RB.md
<https://reviews.apache.org/r/20422/#comment81100>

    s/use RB for all but the most trivial of patches/use RB for non-trivial patches and any
time one seeks feedback on code/



docs/src/main/resources/RB.md
<https://reviews.apache.org/r/20422/#comment81103>

    Add line:
    
    * Avoid submitting generated code for review, if it can be reproduced by a reviewer.



docs/src/main/resources/RB.md
<https://reviews.apache.org/r/20422/#comment81105>

    Consistent word wrapping makes this more readable. (line too long; see also line 96)



docs/src/main/resources/RB.md
<https://reviews.apache.org/r/20422/#comment81107>

    In practice, nobody does this. Consider omitting this suggestion.


- Christopher Tubbs


On April 25, 2014, 10:39 a.m., Bill Havanki wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20422/
> -----------------------------------------------------------
> 
> (Updated April 25, 2014, 10:39 a.m.)
> 
> 
> Review request for accumulo.
> 
> 
> Bugs: ACCUMULO-1834
>     https://issues.apache.org/jira/browse/ACCUMULO-1834
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> A proposed set of guidelines for using Review Board, in deference to our recently-approved
and improved bylaws.
> 
> 
> Diffs
> -----
> 
>   docs/src/main/resources/RB.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/20422/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bill Havanki
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message