accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Park" <parkjs...@gmail.com>
Subject Review Request 22658: ACCUMULO-2889: Batch metadata updates for new WALs
Date Mon, 16 Jun 2014 21:59:57 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22658/
-----------------------------------------------------------

Review request for accumulo.


Bugs: ACCUMULO-2889
    https://issues.apache.org/jira/browse/ACCUMULO-2889


Repository: accumulo


Description
-------

Added additional methods to the Writer class to handle batching. 

Potential risks are that we're now holding onto the locks for a bit longer than we used to.
All tablets present in a batch will have their logLock's locked until the batch is complete.



Diffs
-----

  core/src/main/java/org/apache/accumulo/core/client/impl/Writer.java d6762e7 
  server/base/src/main/java/org/apache/accumulo/server/util/MetadataTableUtil.java 374017d

  server/tserver/src/main/java/org/apache/accumulo/tserver/Tablet.java 36b2289 
  server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServer.java e2510d7 
  server/tserver/src/main/java/org/apache/accumulo/tserver/log/TabletServerLogger.java d25ee75

  test/src/test/java/org/apache/accumulo/test/BatchMetadataUpdatesIT.java PRE-CREATION 

Diff: https://reviews.apache.org/r/22658/diff/


Testing
-------

Added a new IT.

We insert a few entries to tablets and ensure that the relevant entries appear in the WAL
and Metadata Table.
One test case that isn't included yet is verifying that root + metadata table entries are
entered correctly.


Thanks,

Jonathan Park


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message