accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Josh Elser" <josh.el...@gmail.com>
Subject Re: Review Request 22399: ACCUMULO-2876 - use site config for default VolumeManagerImpl
Date Mon, 09 Jun 2014 20:59:21 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22399/#review45139
-----------------------------------------------------------

Ship it!


Please make a follow-on for making Property.GENERAL_VOLUME_CHOOSER a fixed property since
you didn't make that change here. Thanks.

- Josh Elser


On June 9, 2014, 8:47 p.m., Bill Havanki wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22399/
> -----------------------------------------------------------
> 
> (Updated June 9, 2014, 8:47 p.m.)
> 
> 
> Review request for accumulo, Eric Newton and Josh Elser.
> 
> 
> Bugs: ACCUMULO-2876
>     https://issues.apache.org/jira/browse/ACCUMULO-2876
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> This changes VolumeManagerImpl.get() to use the site configuration instead of the ZooKeeper-based
system configuration. This seems to align better with what is intended, and it also eliminates
the risk of an infinite loop, where the system configuration requires an HdfsZooInstance instance
ID, which requires a volume manager.
> 
> 
> Diffs
> -----
> 
>   server/base/src/main/java/org/apache/accumulo/server/fs/VolumeManagerImpl.java 8fe6579

> 
> Diff: https://reviews.apache.org/r/22399/diff/
> 
> 
> Testing
> -------
> 
> All unit tests pass. The fix also rectified the loop in SystemCredentialsTest after refactoring
for ACCUMULO-2615.
> 
> 
> Thanks,
> 
> Bill Havanki
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message