accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Havanki" <bhava...@clouderagovt.com>
Subject Re: Review Request 22308: ACCUMULO-2865 - ZooCacheTest
Date Fri, 06 Jun 2014 18:12:32 GMT


> On June 6, 2014, 1:03 p.m., Mike Drob wrote:
> > fate/src/test/java/org/apache/accumulo/fate/zookeeper/ZooCacheTest.java, line 152
> > <https://reviews.apache.org/r/22308/diff/1/?file=604767#file604767line152>
> >
> >     Should the verify be after the cache hit to make sure the zk code didn't get
called multiple times? Not sure.

My intent is to check that the zk code doesn't get called again, and in my head I thought
the verify would close down the mock so that repeat calls would fail. But, I don't see anything
in the Easymock docs saying that is true. So, I am changing the zk object to a strict mock,
so that extra calls will definitely fail. Thanks for pointing this out!


- Bill


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22308/#review44918
-----------------------------------------------------------


On June 6, 2014, 12:36 p.m., Bill Havanki wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22308/
> -----------------------------------------------------------
> 
> (Updated June 6, 2014, 12:36 p.m.)
> 
> 
> Review request for accumulo.
> 
> 
> Bugs: ACCUMULO-2865
>     https://issues.apache.org/jira/browse/ACCUMULO-2865
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> This adds a unit test for ZooCache. ZooCache itself was only changed slightly, with the
addition of methods to check if information was cached and improvements to its comments.
> 
> 
> Diffs
> -----
> 
>   fate/src/main/java/org/apache/accumulo/fate/zookeeper/ZooCache.java 99ffd04 
>   fate/src/test/java/org/apache/accumulo/fate/zookeeper/ZooCacheTest.java PRE-CREATION

> 
> Diff: https://reviews.apache.org/r/22308/diff/
> 
> 
> Testing
> -------
> 
> Unit tests pass, including ZooCacheTest.
> 
> 
> Thanks,
> 
> Bill Havanki
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message