Return-Path: X-Original-To: apmail-accumulo-dev-archive@www.apache.org Delivered-To: apmail-accumulo-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7D6EA11497 for ; Sat, 17 May 2014 00:42:27 +0000 (UTC) Received: (qmail 4048 invoked by uid 500); 16 May 2014 23:42:08 -0000 Delivered-To: apmail-accumulo-dev-archive@accumulo.apache.org Received: (qmail 2317 invoked by uid 500); 16 May 2014 23:42:05 -0000 Mailing-List: contact dev-help@accumulo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@accumulo.apache.org Delivered-To: mailing list dev@accumulo.apache.org Received: (qmail 45137 invoked by uid 99); 16 May 2014 23:30:07 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 16 May 2014 23:30:07 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 8B9D61D7C34; Fri, 16 May 2014 23:29:52 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2888789514046720861==" MIME-Version: 1.0 Subject: Re: Review Request 21567: ACCUMULO-2816 Ensure LocalWALRecovery looks at WAL. From: "Sean Busbey" To: "Mike Drob" , "Josh Elser" Cc: "Sean Busbey" , "accumulo" Date: Fri, 16 May 2014 23:29:52 -0000 Message-ID: <20140516232952.1685.29483@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Sean Busbey" X-ReviewGroup: accumulo X-ReviewRequest-URL: https://reviews.apache.org/r/21567/ X-Sender: "Sean Busbey" References: <20140516194212.1685.99144@reviews.apache.org> In-Reply-To: <20140516194212.1685.99144@reviews.apache.org> Reply-To: "Sean Busbey" X-ReviewRequest-Repository: accumulo --===============2888789514046720861== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21567/ ----------------------------------------------------------- (Updated May 16, 2014, 11:29 p.m.) Review request for accumulo, Josh Elser and Mike Drob. Changes ------- changed to FileSystem api to avoid manually handling crc files, per discussion with Josh. Bugs: ACCUMULO-2816 https://issues.apache.org/jira/browse/ACCUMULO-2816 Repository: accumulo Description ------- ACCUMULO-2816 Ensure LocalWALRecovery looks at WAL. * consolidated filtering of crc so that underlying fs return order on directory contents doesn't matter * added better error message for reading an invalid wal * fixed v2 vs v3 magic header reading Diffs (updated) ----- server/tserver/src/main/java/org/apache/accumulo/tserver/log/DfsLogger.java eb04f09021f313c2c12ad15f2ae443c368452418 server/tserver/src/main/java/org/apache/accumulo/tserver/logger/LogFileKey.java 1e33569af680079b72dde6e57833b096f5310129 server/tserver/src/test/java/org/apache/accumulo/tserver/log/LocalWALRecoveryTest.java 99190b2a3ae6773f70ce4b5508f1b3dab19cfd3e Diff: https://reviews.apache.org/r/21567/diff/ Testing ------- unit tests pass (they did not on my system prior to this patch) Thanks, Sean Busbey --===============2888789514046720861==--