Return-Path: X-Original-To: apmail-accumulo-dev-archive@www.apache.org Delivered-To: apmail-accumulo-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6F556113CC for ; Sat, 17 May 2014 00:13:09 +0000 (UTC) Received: (qmail 18622 invoked by uid 500); 16 May 2014 23:27:02 -0000 Delivered-To: apmail-accumulo-dev-archive@accumulo.apache.org Received: (qmail 52690 invoked by uid 500); 16 May 2014 23:12:01 -0000 Mailing-List: contact dev-help@accumulo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@accumulo.apache.org Delivered-To: mailing list dev@accumulo.apache.org Received: (qmail 50752 invoked by uid 99); 16 May 2014 23:08:32 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 16 May 2014 23:08:32 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id EF88D1D7C42; Fri, 16 May 2014 23:08:21 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6685632794319849426==" MIME-Version: 1.0 Subject: Re: Review Request 21557: ACCUMULO-2766 fix wal group commit From: keith@deenlo.com To: "Mike Drob" , "accumulo" , keith@deenlo.com Date: Fri, 16 May 2014 23:08:21 -0000 Message-ID: <20140516230821.1686.7770@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: noreply@reviews.apache.org X-ReviewGroup: accumulo X-ReviewRequest-URL: https://reviews.apache.org/r/21557/ X-Sender: noreply@reviews.apache.org References: <20140516191102.6328.44275@reviews.apache.org> In-Reply-To: <20140516191102.6328.44275@reviews.apache.org> Reply-To: keith@deenlo.com X-ReviewRequest-Repository: accumulo --===============6685632794319849426== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit > On May 16, 2014, 7:11 p.m., Mike Drob wrote: > > server/tserver/src/main/java/org/apache/accumulo/tserver/log/DfsLogger.java, line 150 > > > > > > Should explicitly handle InvocationTargetException. Can be done in a follow-on issue. I think it would be cleaner to handle this in another issue. I took a wack at it, because I thought it would be a 2 line change. However getCause() returns a Throwable and all of the plumbing for getting the exception back takes Exception. So a bit more would need to be changed. - kturner ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21557/#review43239 ----------------------------------------------------------- On May 16, 2014, 10:56 p.m., kturner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21557/ > ----------------------------------------------------------- > > (Updated May 16, 2014, 10:56 p.m.) > > > Review request for accumulo. > > > Bugs: ACCUMULO-2766 > https://issues.apache.org/jira/browse/ACCUMULO-2766 > > > Repository: accumulo > > > Description > ------- > > A possible fix for ACCUMULO-2766. > > > Diffs > ----- > > server/tserver/src/main/java/org/apache/accumulo/tserver/log/DfsLogger.java eb04f09 > > Diff: https://reviews.apache.org/r/21557/diff/ > > > Testing > ------- > > Only performance testing so far. This patch dramatically improves performance. > > > Thanks, > > kturner > > --===============6685632794319849426==--