Return-Path: X-Original-To: apmail-accumulo-dev-archive@www.apache.org Delivered-To: apmail-accumulo-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 47CD911D3D for ; Wed, 14 May 2014 04:23:35 +0000 (UTC) Received: (qmail 32944 invoked by uid 500); 14 May 2014 04:16:55 -0000 Delivered-To: apmail-accumulo-dev-archive@accumulo.apache.org Received: (qmail 32901 invoked by uid 500); 14 May 2014 04:16:55 -0000 Mailing-List: contact dev-help@accumulo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@accumulo.apache.org Delivered-To: mailing list dev@accumulo.apache.org Received: (qmail 32889 invoked by uid 99); 14 May 2014 04:16:55 -0000 Received: from Unknown (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 14 May 2014 04:16:55 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 4EEC41D795E; Wed, 14 May 2014 04:16:47 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7050355331367682042==" MIME-Version: 1.0 Subject: Re: Review Request 21169: ACCUMULO-2770 Add utility to read local WAL From: "Mike Drob" To: "Eric Newton" , "Sean Busbey" Cc: "Mike Drob" , "accumulo" , keith@deenlo.com Date: Wed, 14 May 2014 04:16:47 -0000 Message-ID: <20140514041647.4187.28867@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Mike Drob" X-ReviewGroup: accumulo X-ReviewRequest-URL: https://reviews.apache.org/r/21169/ X-Sender: "Mike Drob" References: <20140513175247.634.70788@reviews.apache.org> In-Reply-To: <20140513175247.634.70788@reviews.apache.org> Reply-To: "Mike Drob" X-ReviewRequest-Repository: accumulo --===============7050355331367682042== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21169/ ----------------------------------------------------------- (Updated May 14, 2014, 4:16 a.m.) Review request for accumulo, Sean Busbey and Eric Newton. Changes ------- Clean up the test code. Bugs: ACCUMULO-2770 https://issues.apache.org/jira/browse/ACCUMULO-2770 Repository: accumulo Description (updated) ------- ACCUMULO-2770 Add utility to read local WAL Forward port the upgrade code from 1.5.x into a separate utility so that a user can still read local WALs if they happen to be around. Recreate LogFile{Key,Value} in their old packages so that we can still read the old sequence files that have embedded class names. Modify the utility to optionally accept values as command line options instead of searching around in the configuration settings. Add documentation to the troubleshooting guide to describe usage. commit 2db5ce6186e32c451328154b024951cc5090505f Author: Eric C. Newton Date: Tue Jun 5 13:18:22 2012 +0000 Diffs (updated) ----- core/src/main/java/org/apache/accumulo/core/conf/Property.java 60969bed6d67fd7677ed9349b9acc817b41456de docs/src/main/latex/accumulo_user_manual/chapters/troubleshooting.tex 203fe0c313db84f7cf9842927f8350f149b4ed4b server/tserver/pom.xml f2b47d45b274b510e6ea7bb0bd12e6d9646f29fe server/tserver/src/main/java/org/apache/accumulo/server/logger/LogFileKey.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/server/logger/LogFileValue.java PRE-CREATION server/tserver/src/main/java/org/apache/accumulo/tserver/log/LocalWALRecovery.java PRE-CREATION server/tserver/src/test/java/org/apache/accumulo/tserver/log/LocalWALRecoveryTest.java PRE-CREATION server/tserver/src/test/resources/walog-from-14/550e8400-e29b-41d4-a716-446655440000 PRE-CREATION Diff: https://reviews.apache.org/r/21169/diff/ Testing (updated) ------- Added new unit test for attempting to read the recovered WAL using the DfsLogger class. Thanks, Mike Drob --===============7050355331367682042==--