Return-Path: X-Original-To: apmail-accumulo-dev-archive@www.apache.org Delivered-To: apmail-accumulo-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 0B2F61164B for ; Tue, 6 May 2014 17:51:33 +0000 (UTC) Received: (qmail 2053 invoked by uid 500); 6 May 2014 16:58:43 -0000 Delivered-To: apmail-accumulo-dev-archive@accumulo.apache.org Received: (qmail 2023 invoked by uid 500); 6 May 2014 16:58:43 -0000 Mailing-List: contact dev-help@accumulo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@accumulo.apache.org Delivered-To: mailing list dev@accumulo.apache.org Received: (qmail 2008 invoked by uid 99); 6 May 2014 16:58:43 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 06 May 2014 16:58:43 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 3BFD01D75C8; Tue, 6 May 2014 16:58:36 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6090988925454394439==" MIME-Version: 1.0 Subject: Re: Review Request 21103: ACCUMULO-2775 set plugin configs that are specific to a module in plugins section From: "Christopher Tubbs" To: "Christopher Tubbs" Cc: "accumulo" , "Sean Busbey" Date: Tue, 06 May 2014 16:58:36 -0000 Message-ID: <20140506165836.7613.38099@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Christopher Tubbs" X-ReviewGroup: accumulo X-ReviewRequest-URL: https://reviews.apache.org/r/21103/ X-Sender: "Christopher Tubbs" References: <20140506072502.7613.27529@reviews.apache.org> In-Reply-To: <20140506072502.7613.27529@reviews.apache.org> Reply-To: "Christopher Tubbs" X-ReviewRequest-Repository: accumulo --===============6090988925454394439== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21103/#review42303 ----------------------------------------------------------- -1 This is expected behavior. A build plugin configuration always overrides a pluginManagement configuration. The excludes are explicitly defined in the pluginManagement section so that it does inherit from the parent, rather than the parent override the child. Further, unless we override it in the pluginManagement section, we want to inherit from whatever configuration is defined in the Apache parent POM, if any, rather than override it. The proper way to exlude something at the top level would be to add a configuration section to that top-level pluginManagement section, not to add excludes to the build/plugins/plugin section that declares the execution. - Christopher Tubbs On May 6, 2014, 3:25 a.m., Sean Busbey wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21103/ > ----------------------------------------------------------- > > (Updated May 6, 2014, 3:25 a.m.) > > > Review request for accumulo and Christopher Tubbs. > > > Bugs: ACCUMULO-2775 > https://issues.apache.org/jira/browse/ACCUMULO-2775 > > > Repository: accumulo > > > Description > ------- > > For those modules that have plugin configurations specific to their runs, set the configurations in build/plugins/plugin so that the configuration takes precedence over default configurations set in parent poms. > > > Diffs > ----- > > core/pom.xml 39de12a > examples/simple/pom.xml 2b6ab69 > server/pom.xml bd61fe6 > start/pom.xml 5fc9346 > test/pom.xml ad60054 > > Diff: https://reviews.apache.org/r/21103/diff/ > > > Testing > ------- > > Verified that mvn org.apache.rat:apache-rat-plugin:check passed before and after change on clean checkout. > > > Thanks, > > Sean Busbey > > --===============6090988925454394439==--