accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Christopher Tubbs" <ctubb...@apache.org>
Subject Re: Review Request 21826: Accumulo-2632
Date Fri, 23 May 2014 18:40:14 GMT


> On May 22, 2014, 4:28 p.m., Josh Elser wrote:
> > server/tserver/src/main/java/org/apache/accumulo/tserver/log/DfsLogger.java, line
572
> > <https://reviews.apache.org/r/21826/diff/1/?file=588466#file588466line572>
> >
> >     It looks like this sync invocation got dropped. Did I just miss it moving somewhere?

I think Keith was working on ACCUMULO-2766. Any feature improvement here should probably be
rebased on top of that, to ensure that the concurrency issues are correct.


- Christopher


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21826/#review43764
-----------------------------------------------------------


On May 22, 2014, 3:57 p.m., John McNamee wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21826/
> -----------------------------------------------------------
> 
> (Updated May 22, 2014, 3:57 p.m.)
> 
> 
> Review request for accumulo.
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> The goal was to find a way to increase the write speed in the DfsLogger using compression.
> This patch uses the Snappy compression library and was the most optimum way that I could
find to increase write performance.
> The option to use compression has been made configurable.
> Recovery has been modified to uncompress the WAL if needed.
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/accumulo/core/conf/Property.java 62b0a33 
>   server/tserver/src/main/java/org/apache/accumulo/tserver/log/DecompressingInputStream.java
PRE-CREATION 
>   server/tserver/src/main/java/org/apache/accumulo/tserver/log/DfsLogger.java bfa51d3

>   server/tserver/src/test/java/org/apache/accumulo/tserver/log/DecompressingInputStreamTest.java
PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/21826/diff/
> 
> 
> Testing
> -------
> 
> There is a unit test for the DecryptingInputStream.java, and I ran continuous Ingest/
continuous verify with the agitator on.
> 
> 
> Thanks,
> 
> John McNamee
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message