accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ke...@deenlo.com
Subject Re: Review Request 21557: ACCUMULO-2766 fix wal group commit
Date Fri, 16 May 2014 22:56:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21557/
-----------------------------------------------------------

(Updated May 16, 2014, 10:56 p.m.)


Review request for accumulo.


Changes
-------

patch #2 fixes race condition in DfsLogger.close().  The method had the following race condition
:

 1) Thread 1 calls close() and adds CLOSED_MARKER to workQueue
 2) sync Thread empties queue before Thread 1 enters while loop
 3) Thread 1 sees that workQueue is empty, does not enter while loop, closes logFile
 4) sync Thread tries to sync log file


Bugs: ACCUMULO-2766
    https://issues.apache.org/jira/browse/ACCUMULO-2766


Repository: accumulo


Description
-------

A possible fix for ACCUMULO-2766.


Diffs (updated)
-----

  server/tserver/src/main/java/org/apache/accumulo/tserver/log/DfsLogger.java eb04f09 

Diff: https://reviews.apache.org/r/21557/diff/


Testing
-------

Only performance testing so far.  This patch dramatically improves performance.


Thanks,

kturner


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message