accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sean Busbey" <s...@manvsbeard.com>
Subject Re: Review Request 21567: ACCUMULO-2816 Ensure LocalWALRecovery looks at WAL.
Date Fri, 16 May 2014 21:25:12 GMT


> On May 16, 2014, 9:13 p.m., Mike Drob wrote:
> > server/tserver/src/main/java/org/apache/accumulo/tserver/logger/LogFileKey.java,
lines 44-46
> > <https://reviews.apache.org/r/21567/diff/1/?file=583639#file583639line44>
> >
> >     I'd really like to move this away from using ordinals, but that might be a follow-on
issue.

I'd definitely say follow on issue, since that would be a major compatibility issue. AFAICT,
this is the accepted best practice for turning an enum member into a number and vice versa.


- Sean


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21567/#review43266
-----------------------------------------------------------


On May 16, 2014, 7:42 p.m., Sean Busbey wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21567/
> -----------------------------------------------------------
> 
> (Updated May 16, 2014, 7:42 p.m.)
> 
> 
> Review request for accumulo, Josh Elser and Mike Drob.
> 
> 
> Bugs: ACCUMULO-2816
>     https://issues.apache.org/jira/browse/ACCUMULO-2816
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
>     ACCUMULO-2816 Ensure LocalWALRecovery looks at WAL.
>     
>     * consolidated filtering of crc so that underlying fs return order on directory contents
doesn't matter
>     * added better error message for reading an invalid wal
>     * fixed v2 vs v3 magic header reading
> 
> 
> Diffs
> -----
> 
>   server/tserver/src/main/java/org/apache/accumulo/tserver/log/DfsLogger.java eb04f09021f313c2c12ad15f2ae443c368452418

>   server/tserver/src/main/java/org/apache/accumulo/tserver/logger/LogFileKey.java 1e33569af680079b72dde6e57833b096f5310129

>   server/tserver/src/test/java/org/apache/accumulo/tserver/log/LocalWALRecoveryTest.java
99190b2a3ae6773f70ce4b5508f1b3dab19cfd3e 
> 
> Diff: https://reviews.apache.org/r/21567/diff/
> 
> 
> Testing
> -------
> 
> unit tests pass (they did not on my system prior to this patch)
> 
> 
> Thanks,
> 
> Sean Busbey
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message