accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sean Busbey" <s...@manvsbeard.com>
Subject Re: Review Request 21169: ACCUMULO-2770 Add utility to read local WAL
Date Wed, 14 May 2014 05:12:13 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21169/#review42942
-----------------------------------------------------------

Ship it!



server/tserver/src/main/java/org/apache/accumulo/server/logger/LogFileKey.java
<https://reviews.apache.org/r/21169/#comment76889>

    nit @deprecated javadoc that says this is only here for recovery from incomplete 1.4->1.5
upgrades



server/tserver/src/main/java/org/apache/accumulo/server/logger/LogFileValue.java
<https://reviews.apache.org/r/21169/#comment76890>

    nit @deprecated javadoc that says this is only here for recovery from incomplete 1.4->1.5
upgrades


Please make sure the commit message mentions taht the test 1.4 walog file was generated for
use in this test and contains only synthetic test data.

- Sean Busbey


On May 14, 2014, 4:16 a.m., Mike Drob wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21169/
> -----------------------------------------------------------
> 
> (Updated May 14, 2014, 4:16 a.m.)
> 
> 
> Review request for accumulo, Sean Busbey and Eric Newton.
> 
> 
> Bugs: ACCUMULO-2770
>     https://issues.apache.org/jira/browse/ACCUMULO-2770
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> ACCUMULO-2770 Add utility to read local WAL
> 
> Forward port the upgrade code from 1.5.x into a separate utility so
> that a user can still read local WALs if they happen to be around.
> Recreate LogFile{Key,Value} in their old packages so that we can still
> read the old sequence files that have embedded class names.
> 
> Modify the utility to optionally accept values as command line options
> instead of searching around in the configuration settings.
> 
> Add documentation to the troubleshooting guide to describe usage.
> 
> commit 2db5ce6186e32c451328154b024951cc5090505f
> Author: Eric C. Newton <ecn@apache.org>
> Date:   Tue Jun 5 13:18:22 2012 +0000
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/accumulo/core/conf/Property.java 60969bed6d67fd7677ed9349b9acc817b41456de

>   docs/src/main/latex/accumulo_user_manual/chapters/troubleshooting.tex 203fe0c313db84f7cf9842927f8350f149b4ed4b

>   server/tserver/pom.xml f2b47d45b274b510e6ea7bb0bd12e6d9646f29fe 
>   server/tserver/src/main/java/org/apache/accumulo/server/logger/LogFileKey.java PRE-CREATION

>   server/tserver/src/main/java/org/apache/accumulo/server/logger/LogFileValue.java PRE-CREATION

>   server/tserver/src/main/java/org/apache/accumulo/tserver/log/LocalWALRecovery.java
PRE-CREATION 
>   server/tserver/src/test/java/org/apache/accumulo/tserver/log/LocalWALRecoveryTest.java
PRE-CREATION 
>   server/tserver/src/test/resources/walog-from-14/550e8400-e29b-41d4-a716-446655440000
PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/21169/diff/
> 
> 
> Testing
> -------
> 
> Added new unit test for attempting to read the recovered WAL using the DfsLogger class.
> 
> 
> Thanks,
> 
> Mike Drob
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message