accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Christopher Tubbs" <ctubb...@apache.org>
Subject Re: Review Request 21413: ACCUMULO-2805 exclude unused transitive dep.
Date Wed, 14 May 2014 01:07:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21413/#review42924
-----------------------------------------------------------


dependencyManagement sections only inherit from a parent pom during our build. This change
will not prevent these transitive dependencies from being inherited by projects which depend
on Accumulo. To achieve that, the exclusions should occur in the regular dependency sections,
rather than the dependencyManagement section of the parent POM.

Other than that, this looks good. If you're just trying to exclude this from our build, then
this satisfies that. If you want to exclude it transitively for others, then this is insufficient.

- Christopher Tubbs


On May 13, 2014, 6:39 p.m., Sean Busbey wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21413/
> -----------------------------------------------------------
> 
> (Updated May 13, 2014, 6:39 p.m.)
> 
> 
> Review request for accumulo.
> 
> 
> Bugs: ACCUMULO-2805
>     https://issues.apache.org/jira/browse/ACCUMULO-2805
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> excludes httpcomponents from libthrift dependency
> 
> 
> Diffs
> -----
> 
>   pom.xml 5f1d20f027a1ac315b51baa5eb75ef919534268c 
> 
> Diff: https://reviews.apache.org/r/21413/diff/
> 
> 
> Testing
> -------
> 
> unit tests pass on 1.5. unit tests + sunny ITs pass on 1.6
> 
> 
> Thanks,
> 
> Sean Busbey
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message