accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mike Drob" <md...@mdrob.com>
Subject Re: Review Request 21169: ACCUMULO-2770 Add utility to read local WAL
Date Tue, 13 May 2014 17:43:32 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21169/
-----------------------------------------------------------

(Updated May 13, 2014, 5:43 p.m.)


Review request for accumulo, Sean Busbey and Eric Newton.


Changes
-------

Use correct version of LogFile{Key,Value}


Bugs: ACCUMULO-2770
    https://issues.apache.org/jira/browse/ACCUMULO-2770


Repository: accumulo


Description (updated)
-------

ACCUMULO-2770 Add utility to read local WAL

Forward port the upgrade code from 1.5.x into a separate utility so
that a user can still read local WALs if they happen to be around.
Recreate LogFile{Key,Value} in their old packages so that we can still
read the old sequence files.

Modify the utility to optionally accept values as command line options
instead of searching around in the configuration settings.

Add documentation to the troubleshooting guide to describe usage.

commit 2db5ce6186e32c451328154b024951cc5090505f
Author: Eric C. Newton <ecn@apache.org>
Date:   Tue Jun 5 13:18:22 2012 +0000

ACCUMULO-1264 move !METADATA file delete markers

Description: Move the !METADATA file delete markers out of the
  !METADATA table and to the root table on upgrade.
Author: Eric Newton
Ref: CDH-18697

Modified from commit 5416eef

ACCUMULO-1010 Support upgrades from 1.4 to 1.5

Description: Add steps necessary to move a zk from 1.4 state to 1.5.
  This leaves it in a good state to be picked up by the rest of the
  1.6 upgrade path.
Author: kturner
Ref: CDH-18697

Cherry picking caused a huge mess and it was simpler to manually select
the parts of the upgrade code that we needed based on the 1.5.1 tag.

Gathered from commits 317c669, aa6b4309, and 8811859.

CDH-18697 Add check for older versions

We need to detect
That the version is one four
To do an upgrade

ACCUMULO-2383 Add log4j properties support

Accumulo now looks for either XML or properties files for the Log4J configuration. It will
also heed the log4j.configuration isystem property if it is set. Its MonitorLog4jWatcher
can now load either properties or XML.

(cherry picked from commit cdcc1d4d41bf16e628b87893814a0ae9f627bcdb)

Reason: CM Compatibility
Author: Bill Havanki <bhavanki@cloudera.com>
Ref: CDH-17877

ACCUMULO-2343 Add AsyncSocketAppender

AsyncSocketAppender is a Log4J AsyncAppender with its own internal SocketAppender.
Configuration for either appender can be set on the AsyncSocketAppender itself. An
AsyncSocketAppender can be configured using a Log4J properties file, while an ordinary
AsyncAppender cannot.

(cherry picked from commit 5a72c37eadeca58e670517611f39824f4307321e)

Reason: CM Compatibility
Author: Bill Havanki <bhavanki@cloudera.com>
Ref: CDH-17877

CLOUDERA-BUILD update plugin versions and properties.

* Updates plugin versions that are set by the apache root pom upstream
* Adds properties relied on that are set by apache root pom upstream

CLOUDERA-BUILD. Exempting temporary build/packaging files from RAT licensing checks


CLOUDERA-BUILD forward port example configuration files for CDH4 parcels and packages

Author: Bill Havanki <bhavanki@clouderagovt.com>

CLOUDERA-BUILD. Must work outside of the git branch the project lives in


CLOUDERA-BUILD Specify maven-plugin-plugin 3.2

The upstream maven-plugin module builds using maven-plugin-plugin 3.2, which is called
out in the Apache version 14 root POM. The CDH 4.6.0 root POM does not list the plugin,
and Maven 3.0.4 pulls down maven-plugin-plugin 2.9 instead (and complains that the
plugin version isn't specified, of course). The maven-plugin module build fails for
`mvn package` with the 2.9 plugin.

A bad workaround is to run mvn install first. However, that can cause builds to pull
older artifacts from the local repository instead of artifacts from the same build, via
the Maven reactor.

CDH-18855 use hadoop-tools instead of -distcp

There is no jar made
For M-R-1 Dist-C-P
So use tools instead

CLOUDERA-BUILD. Set cdh-root as parent pom.

Needed to modify some plugins to get a build to work:
 - Increment failsafe-plugin version
 - Increment assembly-plugin version
 - Exclude mockito from hadoop-common
 -- Mockito brings in a different version of Hamcrest than Junit
 - Explicitly define rat-plugin version


Diffs (updated)
-----

  assemble/pom.xml 9ebd2de1939cd91dac67bbf4455500c2231cd74e 
  conf/examples/CDH4_packages/accumulo-env.sh PRE-CREATION 
  conf/examples/CDH4_packages/accumulo-metrics.xml PRE-CREATION 
  conf/examples/CDH4_packages/accumulo-site.xml PRE-CREATION 
  conf/examples/CDH4_packages/generic_logger.xml PRE-CREATION 
  conf/examples/CDH4_packages/log4j.properties PRE-CREATION 
  conf/examples/CDH4_packages/monitor_logger.xml PRE-CREATION 
  conf/examples/CDH4_parcels/accumulo-env.sh PRE-CREATION 
  conf/examples/CDH4_parcels/accumulo-metrics.xml PRE-CREATION 
  conf/examples/CDH4_parcels/accumulo-site.xml PRE-CREATION 
  conf/examples/CDH4_parcels/generic_logger.xml PRE-CREATION 
  conf/examples/CDH4_parcels/log4j.properties PRE-CREATION 
  conf/examples/CDH4_parcels/monitor_logger.xml PRE-CREATION 
  conf/templates/generic_logger.properties PRE-CREATION 
  conf/templates/monitor_logger.properties PRE-CREATION 
  core/pom.xml 9859f92dd8b05a0ca7407cde37155c7fc6ad40c0 
  core/src/main/java/org/apache/accumulo/core/conf/Property.java 60969bed6d67fd7677ed9349b9acc817b41456de

  core/src/main/java/org/apache/accumulo/core/util/AsyncSocketAppender.java PRE-CREATION 
  core/src/test/java/org/apache/accumulo/core/util/AsyncSocketAppenderTest.java PRE-CREATION

  docs/pom.xml dfc7f80d98915c832adf35761a1617e1c43bea5a 
  docs/src/main/latex/accumulo_user_manual/chapters/troubleshooting.tex 203fe0c313db84f7cf9842927f8350f149b4ed4b

  examples/simple/pom.xml 5403cbaa7b30acf530c73a3ca63cecf53f4108a6 
  fate/pom.xml 3232c57ee745c978f73d29738873cf75a9b3c424 
  maven-plugin/pom.xml 990599f7363aa3d69cbb0065baf2e4ea01f1dc16 
  minicluster/pom.xml a489d5c197d47a40c50917477fc641a95dff724c 
  pom.xml 43aa5fb8160fab0d862a1bc1f6a1a87696a9b978 
  proxy/pom.xml b526ee22c51a9c513ff4b30282fc15a1db4f465d 
  server/base/pom.xml 758a40efc22fa124aed575b2b18448b3b1f61a27 
  server/base/src/main/java/org/apache/accumulo/server/Accumulo.java 4e1eb3595cdb6daabb6de39811f9efc36e931f07

  server/base/src/main/java/org/apache/accumulo/server/ServerConstants.java b577abbb72c9dce70b8f12dfefe381d38c48cb8e

  server/base/src/main/java/org/apache/accumulo/server/util/MetadataTableUtil.java 374017d6544a3be5bccb70eab7a994a92f9693ac

  server/base/src/main/java/org/apache/accumulo/server/watcher/MonitorLog4jWatcher.java ac3426e02a48c7358fc4024bc3dbb2374a19b98c

  server/base/src/test/java/org/apache/accumulo/server/AccumuloTest.java 9366163381c1f4a0dd481b28994f4f650249f86e

  server/base/src/test/java/org/apache/accumulo/server/watcher/MonitorLog4jWatcherTest.java
PRE-CREATION 
  server/gc/pom.xml cf806b9f5ccab308172ed636165c5b96096c03f9 
  server/master/pom.xml 0037ad9f9c6d4e3a177eebe9d8ead9d8e02493f9 
  server/master/src/main/java/org/apache/accumulo/master/Master.java 2440ee4bb824007e5cbda8c56b037ccb2d314fab

  server/monitor/pom.xml ccc455ebcd34c34d1f069ffdbef4c896d136c74a 
  server/native/pom.xml 72aa84a92d67b0de2db058dfea972334424575a1 
  server/tracer/pom.xml d9775dcc90d5ce0d8359e54e06315da9e47fd32c 
  server/tserver/pom.xml f66d442c1922c8706b2950f795cd8bd2e4d8a069 
  server/tserver/src/main/java/org/apache/accumulo/server/logger/LogFileKey.java PRE-CREATION

  server/tserver/src/main/java/org/apache/accumulo/server/logger/LogFileValue.java PRE-CREATION

  server/tserver/src/main/java/org/apache/accumulo/tserver/log/LocalWALRecovery.java PRE-CREATION

  server/tserver/src/main/java/org/apache/accumulo/tserver/logger/LogFileKey.java 1e33569af680079b72dde6e57833b096f5310129

  server/tserver/src/main/java/org/apache/accumulo/tserver/logger/LogFileValue.java 997f71b739025caf0bc192e2114bc0de5d9fdb2e

  start/pom.xml ee288a3f3ffb85518d80074ad38376be0967d825 
  test/pom.xml 5d12ba6a0ef42b13be30f4ef8ae28712a629367a 
  test/src/test/java/org/apache/accumulo/test/functional/ConfigurableMacIT.java d9bed7ff13ab1883c5c4017137d8f5bbcbc6124e

  test/src/test/java/org/apache/accumulo/test/functional/MonitorLoggingIT.java PRE-CREATION

  test/src/test/resources/conf/generic_logger.xml PRE-CREATION 
  test/src/test/resources/conf/monitor_logger.xml PRE-CREATION 
  trace/pom.xml f4347d0149505e4e91058d7cc081dd23bbaf0429 

Diff: https://reviews.apache.org/r/21169/diff/


Testing
-------


Thanks,

Mike Drob


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message